Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Chore: Productionize contract package #1442

Merged
merged 11 commits into from
Sep 22, 2024
+80,560 −16,471
Merged

👷 Chore: Productionize contract package #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2515246
:construction_worker: Chore: Productionize contract package
Sep 21, 2024
e4d9798
:rotating_light: Fix: linter
Sep 21, 2024
fd1ed68
:bug: Fix: broken type
Sep 21, 2024
29dcf59
:bug: Feat: Make withCode only take code and return proper generic co…
Sep 21, 2024
b2bc8ed
:white_check_mark: Contrac tpackage done
Sep 21, 2024
5fb90ff
:white_check_mark: Fix: broken builds
Sep 22, 2024
a29bb45
:memo: Regen docs
Sep 22, 2024
2e8e47d
Merge branch 'main' of github.com:evmts/tevm-monorepo into 09-21-_con…
Sep 22, 2024
f0376e7
:bug: Fix: race condition in eth_getTransactionCount
Sep 22, 2024
47a1d68
:white_check_mark: Fix: build
Sep 22, 2024
f3ff7b7
:white_check_mark: Fix: broken test
Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 6 additions & 0 deletions .changeset/large-donkeys-play.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@tevm/procedures": patch
"@tevm/state": patch
---

Fixed race condition in getTransactionCount
5 changes: 5 additions & 0 deletions .changeset/long-plums-march.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tevm/contract": patch
---

Do a jsdoc overhaul of tevm/contract
5 changes: 5 additions & 0 deletions .changeset/poor-colts-learn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tevm/contract": patch
---

Fixed bug where write methods were showing up as both write and read methods
5 changes: 5 additions & 0 deletions .changeset/swift-ducks-lie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tevm/common": minor
---

Removed experimental script property from contract instance. This allows encodeDeployData to treeshake
5 changes: 5 additions & 0 deletions .changeset/twenty-apricots-divide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tevm/contract": minor
---

Added `withCode` method to contract to add code. This replaces the previous script property
Comment on lines +1 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Inconsistency found: 'script:' property still present in codebase

The changeset message states that the 'withCode' method replaces the previous 'script' property. However, our verification reveals that the 'script:' property is still present in multiple files across the codebase. While the 'withCode' method has been implemented and is being used in tests, the transition appears to be incomplete.

Action items:

  • Review all occurrences of 'script:' in the codebase and update them to use 'withCode' where appropriate.
  • Update or remove 'script:' usage in files such as TevmActionsApi.ts, JsonRpcSchemaTevm.ts, and TevmClient.ts.
  • Revise the changeset message to accurately reflect the current state of the changes, possibly indicating that this is a gradual transition rather than a complete replacement.

Please ensure that all necessary updates are made before finalizing this change to maintain consistency and prevent potential issues.

Analysis chain

Changeset looks good! Verify the impact of the breaking change.

The changeset file follows the correct format and provides a clear description of the changes. The addition of the withCode method and removal of the script property seems like a good improvement to streamline the process of adding code to contracts.

However, please ensure that all current usages of the script property are updated to use withCode instead, as this is a breaking change.

Run the following script to verify the usage of the script property:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all usages of the `script` property are updated to use `withCode`.

# Test: Search for the `script` property usage. Expect: No occurrences.
rg --type typescript $'script:'

Length of output: 65

Script:

#!/bin/bash
# Description: Verify all usages of the `script` property are updated to use `withCode`.

# Search for 'script:' in TypeScript files
echo "Searching for 'script:' usage:"
fd '\.(ts|tsx)$' | xargs rg 'script:' -n --context 2

# Search for 'withCode' method in TypeScript files
echo -e "\nSearching for 'withCode' usage:"
fd '\.(ts|tsx)$' | xargs rg 'withCode' -n --context 2

Length of output: 8429

4 changes: 2 additions & 2 deletions bundler-packages/base-bundler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
"./package.json": "./package.json",
Expand Down Expand Up @@ -76,6 +77,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/bun/docs/README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 0 additions & 22 deletions bundler-packages/bun/docs/_media/LICENSE
View file
Open in desktop

This file was deleted.

75 changes: 0 additions & 75 deletions bundler-packages/bun/docs/functions/bunPluginTevm.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions bundler-packages/bun/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
".": {
Expand Down Expand Up @@ -75,6 +76,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/bundler-cache/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
"./package.json": "./package.json",
Expand Down Expand Up @@ -74,6 +75,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
"./package.json": "./package.json",
Expand Down Expand Up @@ -79,6 +80,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
"./package.json": "./package.json",
Expand Down Expand Up @@ -77,6 +78,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/esbuild/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
"./package.json": "./package.json",
Expand Down Expand Up @@ -67,6 +68,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/resolutions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"contributors": [
"Will Cory <[email protected]>"
],
"sideEffects": false,
"type": "module",
"exports": {
"./package.json": "./package.json",
Expand Down Expand Up @@ -74,6 +75,5 @@
},
"publishConfig": {
"access": "public"
},
"sideEffects": false
}
}
4 changes: 2 additions & 2 deletions bundler-packages/rollup/docs/README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 0 additions & 22 deletions bundler-packages/rollup/docs/_media/LICENSE
View file
Open in desktop

This file was deleted.

Loading
Loading