Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Broken tree shaking #1449

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

roninjin10
Copy link
Collaborator

@roninjin10 roninjin10 commented Sep 22, 2024

Description

Concise description of proposed changes

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

Summary by CodeRabbit

  • New Features

    • Updated multiple packages under the @tevm namespace to enhance functionality and performance.
  • Bug Fixes

    • Corrected a typo in the package.json file, improving the treeshaking capability of the tevm project.
    • Standardized the property name from "sideEffect" to "sideEffects" across various package configurations to align with naming conventions.

These changes ensure better package management and adherence to expected standards, enhancing overall user experience.

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
tevm-monorepo-tevm ⬜️ Ignored (Inspect) Sep 22, 2024 7:49pm

Copy link

changeset-bot bot commented Sep 22, 2024

🦋 Changeset detected

Latest commit: 1ed1b71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 55 packages
Name Type
@tevm/sync-storage-persister Patch
@tevm/bundler-cache Patch
@tevm/base-bundler Patch
@tevm/resolutions Patch
@tevm/compiler Patch
@tevm/unplugin Patch
@tevm/whatsabi Patch
@tevm/esbuild-plugin Patch
@tevm/runtime Patch
@tevm/webpack-plugin Patch
@tevm/receipt-manager Patch
@tevm/config Patch
@tevm/rollup-plugin Patch
@tevm/rspack-plugin Patch
@tevm/memory-client Patch
@tevm/solc Patch
@tevm/vite-plugin Patch
@tevm/client-types Patch
@tevm/bun-plugin Patch
@tevm/http-client Patch
@tevm/precompiles Patch
@tevm/blockchain Patch
@tevm/decorators Patch
@tevm/predeploys Patch
@tevm/procedures Patch
@tevm/tsupconfig Patch
@tevm/ethers Patch
@tevm/contract Patch
@tevm/tsconfig Patch
@tevm/actions Patch
@tevm/address Patch
@tevm/jsonrpc Patch
@tevm/viem Patch
@tevm/common Patch
@tevm/effect Patch
@tevm/errors Patch
@tevm/logger Patch
@tevm/server Patch
@tevm/txpool Patch
@tevm/test-utils Patch
@tevm/block Patch
@tevm/state Patch
@tevm/utils Patch
@tevm/ts-plugin Patch
@tevm/node Patch
@tevm/trie Patch
@tevm/evm Patch
@tevm/rlp Patch
@tevm/tx Patch
@tevm/vm Patch
@tevm/lsp Patch
tevm Patch
@tevm/experimental-solc Patch
@tevm/cli Patch
tevm-run Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

coderabbitai bot commented Sep 22, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a patch update for 56 packages under the @tevm namespace, addressing various modifications primarily in the package.json files. The key change involves correcting the property name from "sideEffect" to "sideEffects" across multiple packages, ensuring alignment with standard naming conventions. Additionally, a typo fix was made in one of the files to enhance the effectiveness of treeshaking.

Changes

File(s) Change Summary
.changeset/polite-teachers-worry.md Patch update for 56 packages under the @tevm namespace; typo fix in package.json for treeshaking.
bundler-packages/*/package.json Updated property name from "sideEffect" to "sideEffects" across multiple package configurations.
configs/*/package.json Updated property name from "sideEffect" to "sideEffects" in various configuration files.
extensions/*/package.json Updated property name from "sideEffect" to "sideEffects" in extension configurations.
packages/*/package.json Updated property name from "sideEffect" to "sideEffects" across various package configurations.
test/test-utils/package.json Updated property name from "sideEffect" to "sideEffects" in @tevm/test-utils package.
tevm/package.json Updated property name from "sideEffect" to "sideEffects" in the tevm project.

Possibly related PRs

🐰 In the meadow where bunnies play,
A patch was made, hip-hip-hooray!
Side effects were fixed, oh what a sight,
Packages updated, all done just right!
With JSONs neat, and names in line,
Hoppy changes, oh so fine! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roninjin10 roninjin10 marked this pull request as ready for review September 22, 2024 19:47
@roninjin10 roninjin10 force-pushed the 09-22-_bug_fix_broken_tree_shaking branch from a8a276a to 1ed1b71 Compare September 22, 2024 19:49
@roninjin10 roninjin10 merged commit b53712d into main Sep 22, 2024
8 of 9 checks passed
@roninjin10 roninjin10 deleted the 09-22-_bug_fix_broken_tree_shaking branch September 22, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant