Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to documentation if runners are "throw away" / "single use" #123

Closed
mithro opened this issue Dec 5, 2020 · 5 comments
Closed

Add to documentation if runners are "throw away" / "single use" #123

mithro opened this issue Dec 5, 2020 · 5 comments
Assignees
Labels
question Further information is requested stale

Comments

@mithro
Copy link

mithro commented Dec 5, 2020

This project looks super interesting but I had one question, are the runners thrown away after they run a single job?

According to https://docs.github.com/en/free-pro-team@latest/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security-with-public-repositories;

We recommend that you do not use self-hosted runners with public repositories.

Forks of your public repository can potentially run dangerous code on your self-hosted runner machine by creating a pull request that executes the code in a workflow.

This is not an issue with GitHub-hosted runners because each GitHub-hosted runner is always a clean isolated virtual machine, and it is destroyed at the end of the job execution.

It would be good if the documentation explicitly stated if it behaves (or can be configured to behave) like the GitHub-hosted runners were the runner is thrown away after a single use.

Thanks for your awesome work!

@davidkarlsen
Copy link
Collaborator

See actions/runner#510 for this feature.
You can try enabling it with an env-var like:

- name: ACTIONS_RUNNER_INPUT_ONCE
  value: "true"

@davidkarlsen davidkarlsen added the question Further information is requested label Dec 7, 2020
@davidkarlsen davidkarlsen self-assigned this Dec 7, 2020
@davidkarlsen
Copy link
Collaborator

@mithro did it work out for you?

@mithro
Copy link
Author

mithro commented Dec 9, 2020

@davidkarlsen - Haven't had a chance to test it yet. Probably be a week or two before we get it going.

@davidkarlsen
Copy link
Collaborator

No feedback - closing. Feel free to reopen if needed.

@heilerich
Copy link

The solution suggested in @davidkarlsen 's comment works perfectly for me.

I can't reopen this issue, but I think this should go into the documentation somewhere.

Great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

3 participants