-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EVM benchmarking scripts #23
Conversation
This pull request introduces 4 alerts when merging 5a84a71 into b9a9338 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 61af855 into b9a9338 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good start (assuming all this works).
Please add
Co-authored-by: cdetrio <[email protected]>
To the commit message.
Please check the LGTM warnings. |
6441dd8
to
08fe4de
Compare
This pull request introduces 1 alert when merging 4b9825d into b9a9338 - view on LGTM.com new alerts:
|
Hey @hugo-dc, the ethereum/go-ethereum#20330 has just been merged, so we can use go-ethereum/master now, and any future release of it. Changes are looking good, I will review the python code in detail later. Still pay attention to LGTM warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Co-authored-by
must be separated by single empty line from the commit title.
Build individual Docker images for each evm implementation Co-authored-by: cdetrio <[email protected]>
This pull request fixes 2 alerts when merging 4b755d0 into b9a9338 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 3e3a10b into b9a9338 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging be534d3 into b9a9338 - view on LGTM.com fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging 033e4ff into b9a9338 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 2 when merging aaaf8e1 into b9a9338 - view on LGTM.com new alerts:
fixed alerts:
|
According to this issue: #22
This PR adds the EVM benchmarking scripts and separates the VM's in different Docker files.
@chfast @cdetrio please let me know if you have any comment