Fixed parser error on get metric statistics #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not included e.g. Average, Max, Min, etc.. Added a unit test
pmenhart
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
I've got the same problem parsing our metric stats. Your fix works well, thanks!
I hope this PR will be accepted and added to a release. @cammellos ?
|
@pmenhart thanks for testing it, this PR slipped under my radar, I will have a look today or during the weekend the latest. |
|
This fix works fine for me! 👍 |
cammellos
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically parser logic will not break if certain optional statistic types are not included e.g. Average, Max, Min, etc.. Added a unit test
See issue: #18
Note: Looks like this base repo doesn't use a .formatter.exs or wasn't run against mix format