Migrate esl-select and esl-select-list to uip
#2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natalie-Smirnova
force-pushed
the
chore/migrate-esl-select/esl-select-list-to-playground
branch
from
f1a6584 to
6cd0682
Compare
Natalie-Smirnova
requested review from
a team,
dshovchko,
fshovchko,
NastaLeo,
ala-n,
yadamskaya and
abarmina
and removed request for
a team
ala-n
requested changes
Dec 24, 2024
There was a problem hiding this comment.
There is 2 additional big problems at that moment:
- The examples are too short in size so dropdown can't be shown correctly
We need to make playground area bigger or consider to use nonisolated scope (yes I was suggesting an isolated type, but due to presentation in convenience we probably should fallback to usual demo) - Usually the full demo (when all aspects of its implimenation) is cool, but seeing the result from user perspective I' afraid to see so much stub logic for displaying form data. Probably I was wrong here as well and we need to hide this presentation script. Plus one point to use non isolated scope (Yep sorry again, that was my suggestion, but I'm see that I was wrong)
PS: due to holidays progress may be set on hold, it is not blocking 5.0.0 release and initial 5.0.0 site updates.
…ect-list-to-playground' into chore/migrate-esl-select/esl-select-list-to-playground # Conflicts: # site/views/examples/forms-select-list.njk # site/views/examples/forms-select.njk
Co-authored-by: ala'n (Alexey Stsefanovich) <[email protected]>
ala-n
added
needs review
ala-n
requested changes
Feb 3, 2025
There was a problem hiding this comment.
@Natalie-Smirnova, please take a look at the validation check.
PR is currently not compliant with a repository style guide
PS: make sure you have husky(git hooks) installed and working locally, it seems it should prevent you from making commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2158