Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-media): add play preconditions support for toggle method #2906

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

NastaLeo
Copy link
Collaborator

@NastaLeo NastaLeo commented Feb 3, 2025

Closes: #2892

@NastaLeo NastaLeo requested a review from a team February 3, 2025 10:24
@NastaLeo NastaLeo self-assigned this Feb 3, 2025
@NastaLeo NastaLeo requested review from dshovchko, yadamskaya and fshovchko and removed request for a team February 3, 2025 10:24
@ala-n ala-n added the needs review The PR is waiting for review label Feb 3, 2025
@ala-n ala-n requested review from a team February 3, 2025 12:03
@ala-n ala-n added this to the ⚡ESL: 5.1.0 Minor release milestone Feb 3, 2025
@ala-n ala-n added the require squash No action from PR author required. Marks that current PR will be merged with squash label Feb 3, 2025
Copy link

codeclimate bot commented Feb 3, 2025

Code Climate has analyzed commit be5f994 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 63.4% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit 1f7b8dc into main Feb 4, 2025
6 checks passed
@ala-n ala-n deleted the feat/esl-media-toggle branch February 4, 2025 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review require squash No action from PR author required. Marks that current PR will be merged with squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 esl-media]: toggle method ignores play preconditions
5 participants