Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix #298 #312

Merged
merged 9 commits into from
Dec 13, 2024
Merged

bug fix #298 #312

merged 9 commits into from
Dec 13, 2024

Conversation

Jannis-Mittenzwei
Copy link
Contributor

closes #298

@Jannis-Mittenzwei Jannis-Mittenzwei self-assigned this Dec 10, 2024
@Jannis-Mittenzwei Jannis-Mittenzwei added the bug Unwanted / harmful behavior label Dec 10, 2024
@Jannis-Mittenzwei Jannis-Mittenzwei changed the title bug fix bug fix #298 Dec 10, 2024
Nicoretti
Nicoretti reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the changelog, and mention which issue will be fixed

@Nicoretti
Copy link
Member

@Jannis-Mittenzwei please also update the changelog.

@Nicoretti
Merge branch 'main' into bug/#298-creating-a-single-GitHub-workflow-f…
da16c54 
…ile-fails-if-directory-.github/workflows-exists-already
@Nicoretti
Copy link
Member

Overall look, good nice clean small fix! 👍

@Nicoretti Nicoretti linked an issue Dec 13, 2024 that may be closed by this pull request
✨ Add CLI option to overwrite existing GitHub workflow files #297
Closed
@Nicoretti
Merge branch 'main' into bug/#298-creating-a-single-GitHub-workflow-f…
54845d7 
…ile-fails-if-directory-.github/workflows-exists-already
@Nicoretti Nicoretti enabled auto-merge (squash) December 13, 2024 14:13
@Nicoretti Nicoretti merged commit bdff2a1 into main Dec 13, 2024
32 checks passed
@Nicoretti Nicoretti deleted the bug/#298-creating-a-single-GitHub-workflow-file-fails-if-directory-.github/workflows-exists-already branch December 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti approved these changes

Assignees

@Jannis-Mittenzwei Jannis-Mittenzwei

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
2 participants
@Jannis-Mittenzwei @Nicoretti