Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional cache busting and bundlers #2535

Closed
kamranayub opened this issue Dec 5, 2022 · 0 comments · Fixed by #2663
Closed

Optional cache busting and bundlers #2535

kamranayub opened this issue Dec 5, 2022 · 0 comments · Fixed by #2663
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior help wanted asking for help from the community, may require a certain platform or skill set to implement

Comments

@kamranayub
Copy link
Member

Also mildly annoying is that some implementations of Loadable add a cache busting URL parameter by default whereas others don't, and the bustCache field became private at some point. This seems like the worst possible implementation, I assume it is an oversight :-). For my case, I use a webpack plugin that adds a hash to the filename, so I don't need a cache busting URL parameter, so I did a little hack to disable it by setting the private _bustCache field where it exists here: https://github.com/dcgw/super-metronome-hero/blob/main/resources.ts#L93-L98

Originally posted by @djcsdy in #2522 (reply in thread)

@kamranayub kamranayub added bug This issue describes undesirable, incorrect, or unexpected behavior help wanted asking for help from the community, may require a certain platform or skill set to implement labels Dec 5, 2022
eonarheim added a commit that referenced this issue Jun 15, 2023
Closes #2535

This PR updates `bustCache= false` by default and provides a `bustCache` property on all built in `Resource` implementations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior help wanted asking for help from the community, may require a certain platform or skill set to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant