-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storybook): fix Storybook #1986
Conversation
.storybook/preview.js
Outdated
@@ -1 +1 @@ | |||
import '@storybook/addon-console'; | |||
// import '@storybook/addon-console'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: see if I can/should add this back
webpack.config.js
Outdated
include: /\.min\.js$/ | ||
}) | ||
] | ||
minimize: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need terser plugin for wp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affect the current wp5 minimize? I'm not positive the 'excalibur.min' entrypoint will still be minimized and the 'excalibur' not if we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert this file, and merge the PR. We can chat about tweaking the bundle, perhaps there is a more effiicient way
Things are mostly working but @eonarheim might need help seeing if the Anchor stories are showcasing a bug? Crosses should be centered in the viewport and the actors should all be at (0, 0) too, which is right on top of the cross. |
I think I have these addressed in your branch, I'm going to cherrypick these into main
|
Going to try and get this looking to pass this weekend 🤞 |
@eonarheim things are working, actions look good. One thing I had to add was this: game.currentScene.camera.pos.setTo(game.halfDrawWidth, game.halfDrawHeight); Otherwise the camera seemed to be focused off "center" of the canvas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we need to keep the webpack terser stuff to keep the min vs non-min outputs to continue working properly
I think terser plugin is deprecated but can check that |
===:clipboard: PR Checklist :clipboard:===
==================
Closes #
Changes: