Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): fix Storybook #1986

Merged
merged 26 commits into from
Oct 16, 2021
Merged

Conversation

kamranayub
Copy link
Member

@kamranayub kamranayub commented Aug 6, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #

Changes:

  • Update Storybook configuration
  • Update TypeScript and Webpack support
  • Update to Node 14
  • Polish stories some more
  • Update stories for new API usages

@kamranayub kamranayub added chore Maintenance tasks, like upgrading libraries or release tasks tools labels Aug 6, 2021
@@ -1 +1 @@
import '@storybook/addon-console';
// import '@storybook/addon-console';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: see if I can/should add this back

.storybook/main.js Outdated Show resolved Hide resolved
include: /\.min\.js$/
})
]
minimize: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need terser plugin for wp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect the current wp5 minimize? I'm not positive the 'excalibur.min' entrypoint will still be minimized and the 'excalibur' not if we remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally we need the specific to prevent the automatic terser config from minimizing the non-min'd entrypoint
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this file, and merge the PR. We can chat about tweaking the bundle, perhaps there is a more effiicient way

@kamranayub kamranayub requested a review from eonarheim August 11, 2021 02:56
@kamranayub
Copy link
Member Author

Things are mostly working but @eonarheim might need help seeing if the Anchor stories are showcasing a bug? Crosses should be centered in the viewport and the actors should all be at (0, 0) too, which is right on top of the cross.

image

@eonarheim
Copy link
Member

I think I have these addressed in your branch, I'm going to cherrypick these into main

Things are mostly working but @eonarheim might need help seeing if the Anchor stories are showcasing a bug? Crosses should be centered in the viewport and the actors should all be at (0, 0) too, which is right on top of the cross.

image

@kamranayub
Copy link
Member Author

Going to try and get this looking to pass this weekend 🤞

@kamranayub
Copy link
Member Author

@eonarheim things are working, actions look good. One thing I had to add was this:

game.currentScene.camera.pos.setTo(game.halfDrawWidth, game.halfDrawHeight);

Otherwise the camera seemed to be focused off "center" of the canvas.

@kamranayub kamranayub marked this pull request as ready for review October 9, 2021 13:27
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we need to keep the webpack terser stuff to keep the min vs non-min outputs to continue working properly

@kamranayub
Copy link
Member Author

I think terser plugin is deprecated but can check that

@eonarheim eonarheim merged commit 3061ab3 into main Oct 16, 2021
@eonarheim eonarheim deleted the chore/move-sandbox-to-storybook branch October 16, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance tasks, like upgrading libraries or release tasks hacktoberfest-accepted tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants