refactor: Pointer System #2071

eonarheim · 2021-10-29T13:35:55Z

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
- v0.26.0 milestone ECS refactor
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

This is still work in progress, the goal is for this to be nearly 100% backwards compatible

Re-implement missing API surface
Remove old pointer system
Fix tests

Related #1161 Pointer Refactor

Changes:

Refactors pointer system into ECS style system
Pointer component allows for configuring
Will add the ability to use the collider and or the graphics as the target for pointer events

…feature/pointer-refactor

.eslintrc.json

eonarheim · 2021-10-30T18:26:20Z

Before merge I want to add a story for the new configurations

CHANGELOG.md

src/engine/Engine.ts

src/engine/Events/ExEvent.ts

src/engine/Events/PointerEvents.ts

src/engine/Input/NativePointerButton.ts

src/engine/Input/PointerButton.ts

src/engine/Input/PointerComponent.ts

src/engine/Input/PointerEventReceiver.ts

kamranayub · 2021-10-31T03:13:25Z

src/engine/Input/PointerEventReceiver.ts

+    super.off(event, handler);
+  }
+
+  public update() {


in theory with an internal reference to engine, this could hook into through events right?

Not sure I'm following, can you expand?

src/engine/Input/PointerEventReceiver.ts

src/engine/Input/PointerSystem.ts

Co-authored-by: Kamran Ayub <[email protected]>

src/engine/Input/PointerType.ts

src/engine/Scene.ts

src/engine/Traits/CapturePointer.ts

kamranayub

LGTM, just minor suggestions to fix jsdocs and remove potential future-confusing comments

…feature/pointer-refactor

eonarheim added 5 commits October 6, 2021 23:30

Mostly working

f2f36aa

Pointer component

d6dbfc2

wip: mostly working, needs tests + touch/pointer double counting

efea8f7

wip fix some tests

1d25be4

Unfocus test

9e5144c

eonarheim added the work-in-progress A work in progress pull request, will not be merged until this is removed label Oct 29, 2021

eonarheim added 9 commits October 29, 2021 08:44

Merge branch 'main' of https://github.com/excaliburjs/Excalibur into …

eec1e4a

…feature/pointer-refactor

fix most tests

18a08a4

Fix tests

2bca0ca

Delete old pointer implementation

c5e1df3

Rename pointer types

34f90a3

Add count back

ad23a48

Fix sandbox

ceaa7a4

fix lint

ef50a98

Fix stories

da9ec3e

eonarheim removed the work-in-progress A work in progress pull request, will not be merged until this is removed label Oct 30, 2021

eonarheim changed the title ~~refactor: [WIP] Pointer System refactor~~ refactor: Pointer System refactor Oct 30, 2021

eonarheim commented Oct 30, 2021

View reviewed changes

.eslintrc.json Show resolved Hide resolved

Update changelog

b2d48a4

kamranayub self-requested a review October 31, 2021 02:52