Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2106] Safari 13.1 Does not boot + Safari Pointers #2107

Merged
merged 4 commits into from
Nov 13, 2021
Merged

fix: [#2106] Safari 13.1 Does not boot + Safari Pointers #2107

merged 4 commits into from
Nov 13, 2021

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes: #2106

Changes:

  • Adds media query API fallback for safari
  • Guards against missing Types in safari for pointers

@eonarheim
fix: [#2106] Safari 13.1 Does not boot + Safari Pointers
e806f9c 
Closes: #2106

## Changes:
- Adds media query API fallback for safari
- Guards against missing Types in safari for pointers
@eonarheim
implement browser integration tests
cd86c48
@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Nov 13, 2021
@eonarheim eonarheim merged commit a63cbbe into main Nov 13, 2021
@eonarheim eonarheim deleted the fix/safari-13.1-crash branch November 13, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedeen jedeen jedeen approved these changes

Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine does not boot on Safari 13.1
2 participants
@eonarheim @jedeen