Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): optimize build jobs #2145

Merged
merged 6 commits into from
Dec 4, 2021
Merged

chore(ci): optimize build jobs #2145

merged 6 commits into from
Dec 4, 2021

Conversation

kamranayub
Copy link
Member

@kamranayub kamranayub commented Dec 4, 2021 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Splits single build step into:

  • core build (faster)
  • storybook examples
  • API docs (typedoc)

Changes:

  • Use cache: npm built in to setup-node action
  • Add new jobs
  • Set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true for the other jobs
  • Use --ignore-scripts for other jobs (5-8s speedup)
  • Use new node-version-file: '.nvmrc' support 🎉

@kamranayub kamranayub marked this pull request as ready for review December 4, 2021 03:53
@kamranayub kamranayub requested a review from eonarheim December 4, 2021 03:53
@kamranayub kamranayub changed the title chore(ci): split jobs chore(ci): optimize build jobs Dec 4, 2021
@kamranayub kamranayub requested a review from eonarheim December 4, 2021 04:27
@kamranayub kamranayub merged commit 9eddba3 into main Dec 4, 2021
@kamranayub kamranayub deleted the ci-build-jobs branch December 4, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eonarheim eonarheim eonarheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamranayub @eonarheim