Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2419] child entities inherit parent's scene #2430

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2419

Changes:

  • Actor.scene is now moved to the base type Entity.scene functionality is the same
  • Adds scene to entity add/remove processing

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 22, 2022
@eonarheim eonarheim merged commit f8d818a into main Jul 22, 2022
@eonarheim eonarheim deleted the fix/2419-child-entity-inherit-scene branch July 22, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child entities don't inherit scene from parent, logs warning when killed
1 participant