Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2455][#2456] Entity removing children bugs #2454

Merged
merged 3 commits into from
Aug 8, 2022
Merged

fix: [#2455][#2456] Entity removing children bugs #2454

merged 3 commits into from
Aug 8, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Aug 7, 2022 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2455
Closes #2456

Changes:

  • Unparent children when .kill() is called
  • Fix issue in .removeAllChildren() where the delete would modify the collection while iterating

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Aug 7, 2022
@eonarheim eonarheim mentioned this pull request Aug 7, 2022
Closed
@eonarheim eonarheim changed the title fix: Entity removing children bugs fix: [#2455][#2456] Entity removing children bugs Aug 8, 2022
@eonarheim eonarheim merged commit 8402e6a into main Aug 8, 2022
@eonarheim eonarheim deleted the fix/remove-all-children branch August 8, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
1 participant
@eonarheim