Add actor.oldGlobalPos, deprecate getGlobalPos in favour of globalPos getter #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecate getGlobalRotation for globalRotation getter
github-actions
bot
added
the
enhancement
Deploying excaliburjs with
|
| Latest commit: |
7c9b74c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1eb37e43.excaliburjs.pages.dev |
| Branch Preview URL: | https://feat-2922.excaliburjs.pages.dev |
eonarheim
approved these changes
Apr 8, 2024
|
@mattjennings Sorry it took me so long to merge this! Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
===:clipboard: PR Checklist :clipboard:===
==================
Closes #2922
Changes:
actor.oldGlobalPosreturns the globalPosition from the previous frameactor.getGlobalPos()- useactor.globalPosinsteadactor.getGlobalRotation()- useactor.globalRotationinsteadactor.getGlobalScale()- useactor.globalScaleinsteadThis required some changes to
MotionSystemso thatglobalPoscould be properly captured. Previously, the parent's transform may have already been updated in the system's update when processing a child entity, leading to an incorrectoldGlobalPosvalue. Now, the MotionSystem update captures the entity & all of its children at the same time, skipping any entities that have parents as to not capture them twice over.This also deprecates other
getGlobalXYZ()functions and replaces them with getters for consistency.