Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3128] Unused scene loader locks up engine #3133

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3128

  • Special case when no resources, consider it "loaded"

Closes: #3128

* Special case when no resources, consider it "loaded"
@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 20, 2024
Copy link

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a98742
Status: ✅  Deploy successful!
Preview URL: https://6fa5a398.excaliburjs.pages.dev
Branch Preview URL: https://fix-3128-unused-loader-lock.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit b74872d into main Jul 20, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the fix/3128-unused-loader-lock-up branch July 20, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused scene loader fails scene transitions and locks up engine
1 participant