Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TypeScript compile (tsc) errors with 3.8.2 #1178

Closed
cduff opened this issue Mar 25, 2020 · 4 comments
Closed

[BUG] TypeScript compile (tsc) errors with 3.8.2 #1178

cduff opened this issue Mar 25, 2020 · 4 comments

Comments

@cduff
Copy link

cduff commented Mar 25, 2020

🐛 Bug Report

tsc returns errors after upgrade to 3.8.2, where 3.8.1 worked fine.

node_modules/exceljs/index.d.ts(1319,21): error TS2304: Cannot find name 'HeaderTransformFunction'.
node_modules/exceljs/index.d.ts(1319,47): error TS2304: Cannot find name 'HeaderArray'.
node_modules/exceljs/index.d.ts(1341,16): error TS2304: Cannot find name 'QuoteColumns'.
node_modules/exceljs/index.d.ts(1342,16): error TS2304: Cannot find name 'QuoteColumns'.
node_modules/exceljs/index.d.ts(1346,13): error TS2304: Cannot find name 'RowTransformFunction'.

Lib version: 3.8.2
Alanscut added a commit to Alanscut/exceljs that referenced this issue Mar 25, 2020
@Alanscut
fix issue exceljs#1178
3d01af2
@Alanscut Alanscut mentioned this issue Mar 25, 2020
Merged
@franleplant
Copy link

I just installed the lib and encountered with this error :)

@ghost
Copy link

ghost commented Mar 26, 2020

The same issue. Version 3.7.0 compiles normally. 3.8.0 - also good; 3.8.2 - fails. Seems an author accidentally removed some part of type definitions

Siemienik added a commit that referenced this issue Mar 26, 2020
@Siemienik
Merge pull request #1179 from Alanscut/issue_1178
76d520a 
fix issue #1178 and update index.d.ts
@franleplant
Copy link

Hi @Siemienik do you know when the next release including this fix will be done? can I do anything to help with that?

@Siemienik
Copy link
Member

only @guyonroche has permissions to do that, I'm waiting for the new version too

This was referenced Mar 27, 2020
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@franleplant @Siemienik @cduff