Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptionless.Wpf shouldn't reference System.Windows.Forms #224

Closed
PhyxionNL opened this issue Feb 11, 2020 · 3 comments
Closed

Exceptionless.Wpf shouldn't reference System.Windows.Forms #224

PhyxionNL opened this issue Feb 11, 2020 · 3 comments

Comments

@PhyxionNL
Copy link
Contributor

I see work is done for .NET Core WPF here:
https://github.com/exceptionless/Exceptionless.Net/tree/feature/net-core-wpf
The WPF project shouldn't use WinForms (same for the current tree), if the WinForms exception currently catched is actually required (unlikely if you use WPF) then you can also reference the Windows project and manually call RegisterApplicationThreadExceptionHandler.

@niemyjski
Copy link
Member

Can you do some research into this and submit a pr to that branch. That would be greatly appreciated. We probably didn't need it but it was submitted as part of the previous pr.

@PhyxionNL
Copy link
Contributor Author

It's unneeded, ThreadException is only thrown for exceptions that occur on WinForms threads. If WinForms isn't used, there's no point to add this and only causes this assembly to get loaded unnecessary. If someone actually uses WinForms in combination with WPF then simply include the Windows project and call RegisterApplicationThreadExceptionHandler. I can submit a PR for it.

@PhyxionNL
Copy link
Contributor Author

#225 @niemyjski.

BTW, both Windows and WPF project are currently limited to one client due to the usage of only one static event handler. I don't think multiple clients are often used but that's currently not possible.

niemyjski pushed a commit that referenced this issue Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants