Got wrong MachineName when using Exceptionless client v4.4.0

[witskeeper]

Got wrong MachineName when using Exceptionless client v4.4.0 with ASP.NET Core 3.1.x

Exceptionless v4.3.x works well.

[niemyjski]

What is the difference between process machine name and the environment machine name for you? Also, I'm wondering if we should be falling back to environment machine name if the process.MachineName is empty? (would it ever be empty). Looks like Process.MachineName will return the computer name where the process is running on . https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.process.machinename?view=netcore-3.1 Makes me think we should be using the process instead of the actual machine name.

[witskeeper]

this bug came from v4.4.0 and you can see the changes of code.
old version use process.MachineName when #elif !PORTABLE && !NETSTANDARD1_2

So , we can just use Environment.MachineName now.

[niemyjski]

Thanks for the PR!

[witskeeper]

when will the new version be released ？ @niemyjski

[niemyjski]

We like to try and get a few changes out in each release, can you use a nightly build for now?

[yuefengkai]

If this issues is resolved, please notify me, thank you @niemyjski

[niemyjski]

this issue is resolved and merged in, you can find the nuget packages on our nightly ci feed: https://f.feedz.io/exceptionless/exceptionless/nuget/index.json

[niemyjski]

A new release is building right now: https://github.com/exceptionless/Exceptionless.Net/releases/tag/v4.4.1