Add Exceptionless.Windows&Wpf for dotnet core 3.0 rc #216

rwecho · 2019-09-20T08:03:35Z

Copy windows&wpf project to generate new dotnet core 3.0 version.

CLAassistant · 2019-09-20T08:12:47Z

All committers have signed the CLA.

niemyjski · 2019-09-20T12:10:15Z

@rwecho awesome! Thanks for the pr :). Was there any specific changes needed for core support? I'm wondering what it would take to use the same NuGet package/existing projects as I know we can upgrade the existing via csproj and do multi targeting. I'm guessing you tried this? What issues did you run into? Thanks again

…rsion.

rwecho · 2019-09-20T16:00:10Z

hi @niemyjski Thanks for your reply.
I was afraid of impating the users using the fx version.
The question I met when modified.

'/Images/ErrorFeedback.png' can found in resource.
fix with '/Exceptionless.Wpf.Core;component/Images/ErrorFeedback.png'
I found no reason.
'CrashReportForm.resx' can found in Exceptionless.Windows.
fix with add something in the csproj

 <ItemGroup>
   <EmbeddedResource Update="Dialogs\CrashReportForm.resx">
     <SubType>Designer</SubType>
     <DependentUpon>CrashReportForm.cs</DependentUpon>
   </EmbeddedResource>
 </ItemGroup>

And I add new commits : remove dotnet core version && replace windows with multi targeting.

niemyjski · 2019-09-20T20:36:48Z

Thanks for your help. I think multi targeting is the best approach. I'll help test this as well :).

niemyjski · 2019-10-16T13:40:11Z

I'm just checking in to see how things were going. Did you have any luck merging these?

niemyjski · 2019-11-12T13:30:55Z

@rwecho is there anything I can do to help with this pr?

niemyjski · 2020-01-15T13:36:00Z

@rwecho is there anything I can do to help with this pr?

rwecho · 2020-01-16T11:53:30Z

@niemyjski Sorry for late reply . I am not familiar with appveyor/cla. It warns me build failed and let me sign the license. I don't know what to do.

I thought you will resolve it . But sorry for ignoring this again.

Could you tell me what I should do next ? Thanks.

niemyjski

I left some comments and questions on this review (thanks again for the PR). Do we need to make any build changes for this / maybe simplify the whole build because now the project system can build nuget packages for everything. Also did you run into any issues testing this on .NET 4.5?

niemyjski · 2020-01-16T13:21:06Z

src/Exceptionless/Exceptionless.csproj

@@ -7,7 +7,7 @@
    <AssemblyTitle>Exceptionless client for non visual (ie. Console and Services) applications.</AssemblyTitle>
    <Description>Exceptionless client for portable applications. $(Description)</Description>
    <PackageTags>Exceptionless;Error;Report;Reporting;Exception;Logging;Log;ELMAH;pcl;NETSTANDARD;Core</PackageTags>
-    <TargetFrameworks>netstandard1.2;netstandard1.3;netstandard1.4;netstandard1.5;netstandard2.0;portable46-net451+win81+wpa81;net45</TargetFrameworks>


I think we still need to support this, any reason this was removed?

I forgot to add it again. Because I can not compile success on my pc environment.

niemyjski · 2020-01-16T13:21:23Z

src/Platforms/Exceptionless.Windows/Exceptionless.Windows.csproj

-    <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">$(MSBuildProjectDirectory)\..\..\..\</SolutionDir>
-    <RestorePackages>true</RestorePackages>
+    <TargetFrameworks>netcoreapp3.0;net45</TargetFrameworks>
+    <UseWindowsForms>true</UseWindowsForms>


What does this do?

UseWindowsForms label providers Microsoft.WindowsDesktop.App.WindowsForms framework collections.
It's along with project created, same with UseWPF

niemyjski · 2020-01-16T13:22:46Z

src/Platforms/Exceptionless.Wpf/Properties/AssemblyInfo.cs

@@ -5,6 +5,5 @@

 [assembly: CLSCompliant(true)]
 [assembly: ComVisible(false)]
-[assembly: AssemblyTitle("Exceptionless.Wpf")]


Any reason for removing this?

same to the above AssemblyTitle reason.

niemyjski · 2020-01-16T13:23:16Z

src/Platforms/Exceptionless.Wpf/Dialogs/CrashReportDialog.xaml

@@ -22,7 +26,7 @@
                [AppName] has encountered a problem and needs to close.  We are sorry for the inconvenience.
            </TextBlock>
            <Image Name="errorImage" Grid.Column="2"  
-                   Source="../Images/ErrorFeedback.png" 
+                   Source="/Exceptionless.Wpf.Core;component/Images/ErrorFeedback.png" 


Where did this core namespace come from? Is this correct?

I forgot to modify it, when migrating from Exceptionless.Wpf.Core. I'll fix it.

niemyjski · 2020-01-16T13:23:22Z

src/Platforms/Exceptionless.Wpf/Dialogs/CrashReportDialog.xaml

        Background="{DynamicResource {x:Static SystemColors.ControlBrushKey}}"
        FocusManager.FocusedElement="{Binding ElementName=DescriptionTextBox}"
-        Icon="../Images/ErrorFeedback.png">
+        Icon="/Exceptionless.Wpf.Core;component/Images/ErrorFeedback.png"


Where did this core namespace come from? Is this correct?

I forgot to modify it, when migrating from Exceptionless.Wpf.Core. I'll fix it.

niemyjski · 2020-01-16T13:23:35Z

src/Platforms/Exceptionless.Windows/Properties/AssemblyInfo.cs

@@ -4,6 +4,5 @@

 [assembly: CLSCompliant(true)]
 [assembly: ComVisible(false)]
-[assembly: AssemblyTitle("Exceptionless.Windows")]


Any reason for removing this?

This will produce error CS0579: Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute. The csproj will generate title attribute same with project name, this should be written in the in the csporj.

duplicate error
msdn about csproj

samples/Exceptionless.SampleWindows/Exceptionless.SampleWindows.csproj

rwecho

Hi @niemyjski thanks for your patience to give directions. I did some work according to your reviews.

upgrade to .NET Core 3.1
restore portable46-net451+win81+wpa81 for project Exceptionless
fix icons error namespace.

samples/Exceptionless.SampleWindows/Exceptionless.SampleWindows.csproj

rwecho · 2020-01-19T07:50:30Z

src/Exceptionless/Exceptionless.csproj

@@ -7,7 +7,7 @@
    <AssemblyTitle>Exceptionless client for non visual (ie. Console and Services) applications.</AssemblyTitle>
    <Description>Exceptionless client for portable applications. $(Description)</Description>
    <PackageTags>Exceptionless;Error;Report;Reporting;Exception;Logging;Log;ELMAH;pcl;NETSTANDARD;Core</PackageTags>
-    <TargetFrameworks>netstandard1.2;netstandard1.3;netstandard1.4;netstandard1.5;netstandard2.0;portable46-net451+win81+wpa81;net45</TargetFrameworks>


I forgot to add it again. Because I can not compile success on my pc environment.

rwecho · 2020-01-19T08:11:52Z

src/Platforms/Exceptionless.Windows/Exceptionless.Windows.csproj

-    <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">$(MSBuildProjectDirectory)\..\..\..\</SolutionDir>
-    <RestorePackages>true</RestorePackages>
+    <TargetFrameworks>netcoreapp3.0;net45</TargetFrameworks>
+    <UseWindowsForms>true</UseWindowsForms>


UseWindowsForms label providers Microsoft.WindowsDesktop.App.WindowsForms framework collections.
It's along with project created, same with UseWPF

rwecho · 2020-01-19T08:26:22Z

src/Platforms/Exceptionless.Wpf/Properties/AssemblyInfo.cs

@@ -5,6 +5,5 @@

 [assembly: CLSCompliant(true)]
 [assembly: ComVisible(false)]
-[assembly: AssemblyTitle("Exceptionless.Wpf")]


same to the above AssemblyTitle reason.

rwecho · 2020-01-19T08:26:30Z

src/Platforms/Exceptionless.Wpf/Dialogs/CrashReportDialog.xaml

@@ -22,7 +26,7 @@
                [AppName] has encountered a problem and needs to close.  We are sorry for the inconvenience.
            </TextBlock>
            <Image Name="errorImage" Grid.Column="2"  
-                   Source="../Images/ErrorFeedback.png" 
+                   Source="/Exceptionless.Wpf.Core;component/Images/ErrorFeedback.png" 


I forgot to modify it, when migrating from Exceptionless.Wpf.Core. I'll fix it.

rwecho · 2020-01-19T08:26:32Z

src/Platforms/Exceptionless.Wpf/Dialogs/CrashReportDialog.xaml

        Background="{DynamicResource {x:Static SystemColors.ControlBrushKey}}"
        FocusManager.FocusedElement="{Binding ElementName=DescriptionTextBox}"
-        Icon="../Images/ErrorFeedback.png">
+        Icon="/Exceptionless.Wpf.Core;component/Images/ErrorFeedback.png"


I forgot to modify it, when migrating from Exceptionless.Wpf.Core. I'll fix it.

rwecho · 2020-01-19T08:26:35Z

src/Platforms/Exceptionless.Windows/Properties/AssemblyInfo.cs

@@ -4,6 +4,5 @@

 [assembly: CLSCompliant(true)]
 [assembly: ComVisible(false)]
-[assembly: AssemblyTitle("Exceptionless.Windows")]


This will produce error CS0579: Duplicate 'System.Reflection.AssemblyTitleAttribute' attribute. The csproj will generate title attribute same with project name, this should be written in the in the csporj.

duplicate error
msdn about csproj

niemyjski

Thanks for the PR! We need to test this like crazy before merging which I'll start this process here this week or next (traveling a bunch this week). If you could help test and list the platforms tested that would be a huge help!

niemyjski · 2020-01-29T13:40:15Z

Thanks for the PR! I merged it into a branch so I can continue testing it and update the build if required.

* add winform & wpf for dotnet core 3.0 preview. * add nuget script * remove core projects for dotnet core 3.0 and will replaced with fx version. * replace fx version with multi targeting * fix obsolete namepsace. * upgrade .NET Core 3.1 * restore frameworks portable46-net451+win81+wpa81 Co-authored-by: Blake Niemyjski <[email protected]>

rwecho added 2 commits September 20, 2019 15:48

add winform & wpf for dotnet core 3.0 preview.

528e8a8

add nuget script

ef7e63f

niemyjski added enhancement investigating labels Sep 20, 2019

rwecho added 2 commits September 20, 2019 23:36

remove core projects for dotnet core 3.0 and will replaced with fx ve…

b1cbc5b

…rsion.

replace fx version with multi targeting

734c040

rwecho requested a review from niemyjski January 16, 2020 11:45

niemyjski requested changes Jan 16, 2020

View reviewed changes

niemyjski reviewed Jan 16, 2020

View reviewed changes

samples/Exceptionless.SampleWindows/Exceptionless.SampleWindows.csproj Outdated Show resolved Hide resolved

rwecho added 3 commits January 19, 2020 16:35

fix obsolete namepsace.

7426326

upgrade .NET Core 3.1

8dbb808

restore frameworks portable46-net451+win81+wpa81

524bc0a

rwecho commented Jan 19, 2020

View reviewed changes

rwecho requested a review from niemyjski January 19, 2020 08:47

Merge branch 'master' into master

e0aa582

niemyjski approved these changes Jan 21, 2020

View reviewed changes

niemyjski added help wanted testing Needs Testing and removed investigating labels Jan 21, 2020

niemyjski changed the base branch from master to feature/net-core-wpf January 29, 2020 13:39

niemyjski merged commit dca0334 into exceptionless:feature/net-core-wpf Jan 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Exceptionless.Windows&Wpf for dotnet core 3.0 rc #216

Add Exceptionless.Windows&Wpf for dotnet core 3.0 rc #216

rwecho commented Sep 20, 2019

CLAassistant commented Sep 20, 2019 •

edited

Loading

niemyjski commented Sep 20, 2019

rwecho commented Sep 20, 2019 •

edited

Loading

niemyjski commented Sep 20, 2019

niemyjski commented Oct 16, 2019

niemyjski commented Nov 12, 2019

niemyjski commented Jan 15, 2020

rwecho commented Jan 16, 2020

niemyjski left a comment

niemyjski Jan 16, 2020

rwecho Jan 19, 2020

niemyjski Jan 16, 2020

rwecho Jan 19, 2020

niemyjski Jan 16, 2020

rwecho Jan 19, 2020

niemyjski Jan 16, 2020

rwecho Jan 19, 2020

niemyjski Jan 16, 2020

rwecho Jan 19, 2020

niemyjski Jan 16, 2020

rwecho Jan 19, 2020

rwecho left a comment

rwecho Jan 19, 2020

rwecho Jan 19, 2020

rwecho Jan 19, 2020

rwecho Jan 19, 2020

rwecho Jan 19, 2020

rwecho Jan 19, 2020

niemyjski left a comment

niemyjski commented Jan 29, 2020

Add Exceptionless.Windows&Wpf for dotnet core 3.0 rc #216

Add Exceptionless.Windows&Wpf for dotnet core 3.0 rc #216

Conversation

rwecho commented Sep 20, 2019

CLAassistant commented Sep 20, 2019 • edited Loading

niemyjski commented Sep 20, 2019

rwecho commented Sep 20, 2019 • edited Loading

niemyjski commented Sep 20, 2019

niemyjski commented Oct 16, 2019

niemyjski commented Nov 12, 2019

niemyjski commented Jan 15, 2020

rwecho commented Jan 16, 2020

niemyjski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwecho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niemyjski left a comment

Choose a reason for hiding this comment

niemyjski commented Jan 29, 2020

CLAassistant commented Sep 20, 2019 •

edited

Loading

rwecho commented Sep 20, 2019 •

edited

Loading