Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip pattern maching for empty sets #258

Merged
merged 4 commits into from
Dec 30, 2021
Merged

Skip pattern maching for empty sets #258

merged 4 commits into from
Dec 30, 2021

Conversation

benaadams
Copy link
Contributor

Gets called a lot with empty sets so can skip that and the HashSet creation and use string[] directly

@benaadams benaadams marked this pull request as draft May 10, 2021 04:29
@benaadams benaadams marked this pull request as ready for review May 10, 2021 04:39
niemyjski
niemyjski approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Not sure why I never got notified for this until now. These changes look good to me.

@niemyjski niemyjski merged commit e8efdf9 into exceptionless:master Dec 30, 2021
@benaadams benaadams deleted the Empty-pattern-macthing branch December 30, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niemyjski niemyjski niemyjski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @niemyjski