Fixes #127: Added ability to record http headers #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Not sure how the string[] array will get handled by Exceptionless though. Should we just have it be a comma delimited string of header values? |
|
We need to update the backend first, but I'd rather do an array here than a comma delimited list as it would be easier to render out and then you have no issues escaping existing values that might have a comma. |
niemyjski
force-pushed
the
feature/header-support
branch
from
38d7828 to
65c9a4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this we probably need to make these changes server side as well.
I also want to add MAX_DATA_ITEM_LENGTH to the other two implementations.