Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug where Application.ThreadException, HttpApplication.Error, Application.Current.DispatcherUnhandledException may not be logged #308

Merged
merged 1 commit into from
May 18, 2023
Merged

Fixed a bug where Application.ThreadException, HttpApplication.Error, Application.Current.DispatcherUnhandledException may not be logged #308

merged 1 commit into from
May 18, 2023

Conversation

niemyjski
Copy link
Member

Also improved logging

2023-05-18 07:35:46.3627 Info  ExceptionlessClient: Startup finished
2023-05-18 07:35:51.7581 Info  ExceptionlessClient: Application.Current.DispatcherUnhandledException called
2023-05-18 07:35:57.5818 Info  ExceptionlessClient: Processing event queue
2023-05-18 07:35:57.8918 Info  DefaultEventQueue: Sent 1 events to "http://localhost".
2023-05-18 07:35:57.8927 Info  ExceptionlessClient: Application.Current.DispatcherUnhandledException finished
2023-05-18 07:35:58.8683 Info  ExceptionlessClient: AppDomain.CurrentDomain.UnhandledException called
2023-05-18 07:35:58.8703 Info  ErrorPlugin: Event submission cancelled by plugin: refid= type=error message=
2023-05-18 07:35:58.8704 Info  ExceptionlessClient: Event submission cancelled by event pipeline: refid= type=error message=
2023-05-18 07:35:58.8704 Info  ExceptionlessClient: Processing event queue
2023-05-18 07:35:58.8704 Info  ExceptionlessClient: AppDomain.CurrentDomain.UnhandledException finished

@niemyjski
Fixed a bug where Application.ThreadException, HttpApplication.Error,…
22c672f 
… Application.Current.DispatcherUnhandledException may not be logged
@niemyjski niemyjski added the bug label May 18, 2023
@niemyjski niemyjski requested a review from ejsmith May 18, 2023 12:40
@niemyjski niemyjski self-assigned this May 18, 2023
niemyjski
niemyjski commented May 18, 2023
View reviewed changes
Copy link
Member Author

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Reviewed

@niemyjski niemyjski merged commit fda1479 into main May 18, 2023
@niemyjski niemyjski deleted the bugfix/async-event-handler branch May 18, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejsmith ejsmith Awaiting requested review from ejsmith

Assignees

@niemyjski niemyjski

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niemyjski