Ensure prefixes are unique #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two or more models are defined with the same prefix, `PrefixedIds.find` will load the model for whichever one was defined last, and could lead to loading an unexpected model for a given prefixed id. For apps with lots of models it’s quite easy to add the same prefix on two or more models by mistake. It’s also not obvious how to access or list the prefixes already in use, so I think it makes sense for the gem to protect against this. This PR adds a check when calling `has_prefix_id` and raises `PrefixedIds::Error` if the same prefix was already defined for a different model.
|
Good idea @samoli. I hadn't considered two models using the same prefix. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two or more models are defined with the same prefix,
PrefixedIds.findwill load the model for whichever one was defined last, and could lead to loading an unexpected model for a given prefixed id.For apps with lots of models it’s quite easy to add the same prefix on two or more models by mistake. It’s also not obvious how to access or list the prefixes already in use, so I think it makes sense for the gem to protect against this.
This PR adds a check when calling
has_prefix_idand raisesPrefixedIds::Errorif the same prefix was already defined for a different model.