Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ UPGRADE: nbconvert 6 support #326

Merged
merged 1 commit into from
May 12, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 9, 2021

@welcome
Copy link

welcome bot commented May 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@bollwyvl bollwyvl mentioned this pull request May 9, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #326 (f3b465e) into master (6be37cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          12       12           
  Lines        1336     1336           
=======================================
  Hits         1168     1168           
  Misses        168      168           
Flag Coverage Δ
pytests 87.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be37cd...f3b465e. Read the comment docs.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@chrisjsewell chrisjsewell changed the title loosen nbconvert pin ⬆️ UPGRADE: nbconvert 6 support May 12, 2021
@chrisjsewell chrisjsewell merged commit ce5f69c into executablebooks:master May 12, 2021
@welcome
Copy link

welcome bot commented May 12, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@bollwyvl
Copy link
Contributor Author

bollwyvl commented May 12, 2021 via email

@ErikBjare
Copy link

Any chance a new PyPI release will be out with this soon?

nbconvert 5 has started breaking my builds: https://stackoverflow.com/a/67061046/965332

@choldgraf
Copy link
Member

I'm pretty sure that a new release is relatively imminent (we also need to bring in a new version of myst-parser)...not sure what's remaining to be done though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nbconvert 6?
4 participants