Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar animation transition no longer works #330

Closed
choldgraf opened this issue May 5, 2021 · 3 comments · Fixed by #333
Closed

Sidebar animation transition no longer works #330

choldgraf opened this issue May 5, 2021 · 3 comments · Fixed by #333
Labels
bug Something isn't working 🏷️ design Related to look and feel of the theme

Comments

@choldgraf
Copy link
Member

Describe the bug

After the latest PyData Sphinx Theme upgrade, I think our sidebar animation stopped working. It now just "snaps" into its end state. I'm not sure what exactly changed :-/

To Reproduce

Go to the sphinx book theme docs and click the "hide sidebar" button.

cc @DrDrij - any chance you've got an idea what might be wrong?

@choldgraf choldgraf added bug Something isn't working 🏷️ design Related to look and feel of the theme labels May 5, 2021
@DrDrij
Copy link
Contributor

DrDrij commented May 7, 2021

Hi @choldgraf.

These lines that were removed are for adding the animation to the bootstrap functions.

We could re-add them? Or I could have another pass early next week to simplify and avoid future issues.

&.collapse { visibility: hidden; margin-left: -$leftbar-width; opacity: 0; display: block; &.show { visibility: visible; margin-left: 0; opacity: 1; } }

@choldgraf
Copy link
Member Author

For sure - I was only removing them because much of the sidebar css had now been incorporated into the pydata theme so i was removing it here to avoid duplication. I just didn't realize i was deleting this functionality in the process haha. Let's add it back in 👍

@choldgraf
Copy link
Member Author

#333 tries to add them back in per your suggestions, let me know if that looks OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏷️ design Related to look and feel of the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants