-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆ UPGRADE: Pydata Sphinx Theme v0.6.0 #324
Conversation
14a7530
to
3de44de
Compare
OK updated the tests and cleaned up some of the code. I think that this is ready to go whenever we'd like to merge. @DrDrij let me know if you'd like me to hold off merging so that this doesn't mess with some work you're doing. Also speak now @executablebooks/ebpteam if you really wanted to be able to collapse the sidebar TOC entirely (so that only captions are shown and no links) via |
@@ -12,17 +12,6 @@ | |||
transition: margin-left .2s ease 0s, opacity .2s ease 0s, visibility .2s ease 0s; | |||
z-index: 2000 !important; | |||
|
|||
&.collapse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@choldgraf These styles add the slide animation to left sidebar.
This is a first pass at upgrading to the latest pydata sphinx theme, and removing our custom sidebar collapsing code to use it instead. This should remove a bunch of our CSS +
__init__.py
code, as well as some testing infrastructure for the sidebar collapsing logic.Note - this will remove one feature for us, which is
navbar_depth = 0
. This would have removed all navbar items except for captions (and made them collapsible). The pydata theme does not support collapsible captions so this will remove this functionality. That said:navbar_depth = 0
so I think it is OK to remove, but welcome others suggesting otherwise!
closes #323
ToDo