✨ ENHANCE: Soften edges in admonitions and remove some ink #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
changed the title
|
I like the rounded edges, but miss the left hand side bolder color. |
|
The latest push takes @pradyunsg and @cooperrc 's advice and keeps the left border, but rounds the edges and controls the box shadow a bit:
|
choldgraf
changed the title
choldgraf
changed the title
|
thanks for the feedback all - this is a much more subtle but I think nicer addition :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment at implementing #351
It rounds the corners of our admonitions and uses a grey border rather than a drop shadow. It also makes the "previous/next" buttons use bolded text without a border.
Tasks