ENH: CSS only sidebar toggling #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious if @pradyunsg has any other suggestions here, or if this looks mostly reasonable to you :-) cc also @AakashGfude since this restructures a little bit of the HTML |
pradyunsg
reviewed
Jan 14, 2022
| @@ -9,7 +9,12 @@ | |||
|
|
|||
| <!-- Docs TOC is "d-none d-xl-block col-xl-2" --> | |||
| {% block docs_sidebar %} | |||
| <div class="col-12 {{ sidebar_width_class }} bd-sidebar site-navigation show{% if is_single_page %} single-page{% endif %}" id="site-navigation"> | |||
| <!-- Checkboxes to toggle the left sidebar --> | |||
| <input type="checkbox" class="sidebar-toggle" name="__navigation" id="__navigation"> | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updates our left sidebar behavior so that instead of using javascript functions to control the display of the left sidebar with a class, instead we use a CSS input box +
:checkedto toggle its visibility. This will make these pages a bit lighter and less-complex, and make them more robust if wonky things happen with javascript on the page.It also implements Furo-style left sidebar behavior on mobile devices, so that the whole left sidebar pops up in an overlay and you close it by clicking elsewhere on the screen.
Old behavior
(shown on widescreen first, then mobile) (sorry for the red tint)
New behavior
Note that the left TOC closes automatically, because it will be hidden by default on pageload on mobile
Refs
closes #366
closes #355
closes jupyter-book/jupyter-book#1379
closes jupyter-book/jupyter-book#1361
closes jupyter-book/jupyter-book#950