Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update CSS for external packages and remove redundant code #478

Merged
merged 13 commits into from
Feb 9, 2022

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Feb 6, 2022

This PR does a few follow-ups to #471 , it:

Todo

@choldgraf choldgraf changed the title MAINT: Minor updates to CSS for external packages MAINT: Update CSS for external packages and remove redundant code Feb 7, 2022
@choldgraf
Copy link
Member Author

choldgraf commented Feb 7, 2022

OK I think this one is ready to go - fixed all of the little bugs we found and made some other general improvements to the structure. Will leave it open for a day or two in case others have feedback

cc @mathbunnyru - I think this fixes the safari fullscreen bug. Wanna try it at: https://sphinx-book-theme--478.org.readthedocs.build/en/478/ ?

@mathbunnyru
Copy link

@choldgraf it half-works :)
So, it goes to the fullscreen, when I press the button in Safari.
But when I press it again, it doesn't go to normal mode and stays full screen (it works well in Chrome).

@choldgraf
Copy link
Member Author

ok @mathbunnyru try again!

@mathbunnyru
Copy link

Seems to work now, thanks!

@choldgraf choldgraf merged commit f425732 into executablebooks:master Feb 9, 2022
@choldgraf choldgraf deleted the maint-packages branch February 9, 2022 20:10
@choldgraf
Copy link
Member Author

OK merging this one in as the next step towards our CSS refactor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants