-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Update CSS for external packages and remove redundant code #478
Conversation
OK I think this one is ready to go - fixed all of the little bugs we found and made some other general improvements to the structure. Will leave it open for a day or two in case others have feedback cc @mathbunnyru - I think this fixes the safari fullscreen bug. Wanna try it at: https://sphinx-book-theme--478.org.readthedocs.build/en/478/ ? |
@choldgraf it half-works :) |
ok @mathbunnyru try again! |
Seems to work now, thanks! |
OK merging this one in as the next step towards our CSS refactor! |
This PR does a few follow-ups to #471 , it:
Todo
closes Fix regressions with a few extensions #476
content-blocks
for ex.closes Fullscreen mode doesn't work in Safari #477
closes Get our lighthouse scores to "good" in relevant categories #468