Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Allowing inline elements in sidenotes and marginnotes #641

Merged
merged 5 commits into from
Nov 8, 2022
Merged

ENH: Allowing inline elements in sidenotes and marginnotes #641

merged 5 commits into from
Nov 8, 2022

Conversation

AakashGfude
Copy link
Member

fixes #612

@AakashGfude AakashGfude changed the title ENH: Allowing inline elements in sidenotes ENH: Allowing inline elements in sidenotes and marginnotes Nov 8, 2022
choldgraf
choldgraf reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice implementation to me - can you see what's up w/ the tests?

choldgraf
choldgraf approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks for fixing it up!

@AakashGfude
Copy link
Member Author

Thanks @choldgraf for the review. I will merge this one, once rest of the tests are done.

@AakashGfude AakashGfude merged commit 628f7f2 into master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow inline elements in sidenotes
2 participants
@AakashGfude @choldgraf