Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functions exercise #833

Merged
merged 3 commits into from
Mar 6, 2024
Merged

feat: add functions exercise #833

merged 3 commits into from
Mar 6, 2024

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Mar 4, 2024

That has slipped, sorry.
I finished the concept but never made the respective exercise.

@vaeng vaeng added x:action/proofread Proofread text x:module/concept-exercise Work on Concept Exercises x:rep/large Large amount of reputation labels Mar 4, 2024
@vaeng vaeng changed the title Feat add functions exercise feat: add functions exercise Mar 4, 2024
exercises/concept/lasagna-master/.docs/instructions.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main comment would be that this exercise is quite "meaty," in introducing a lot. Function/overloading and default parameters go well together I think. Const could potentially be its own exercise, but it's also fine to just keep it as is for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I once had an extra exercise for const planned and I have evaluated C#'s "Authentication System" exercise. I am not sure it is a good fit.
Siebenschläfer also suggested, that the const could be moved, but we need to visit constexpr and const in classes again, so there will be some repetition and I planned to sprinkle it here and there to make it easier to digest.

If we keep it this way, we should watch the numbers and split some of it away, if users don't find it as well fitting as I did while writing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@vaeng vaeng merged commit aa0ec1f into main Mar 6, 2024
4 checks passed
@vaeng vaeng deleted the feat--add-functions-exercise branch March 6, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/proofread Proofread text x:module/concept-exercise Work on Concept Exercises x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants