docs: fix instructions of lasagna master #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions of Task 3 have been clarified.
vaeng
reviewed
Apr 1, 2024
vaeng
reviewed
Apr 2, 2024
Co-authored-by: Christian Willner <[email protected]>
|
Can we proceed merging the PR @vaeng? |
vaeng
approved these changes
May 28, 2024
vaeng
changed the title
iHiD
reviewed
May 29, 2024
| Write a function `addSecretIngredient` that accepts two `string` vectors of ingredients as parameters. | ||
| The first parameter is the list your friend sent you, the second is the ingredient list of your own recipe. | ||
| Write a function `addSecretIngredient` that accepts two `vector of strings` as parameters. | ||
| The first parameter is a _reference_ to the ingredients of your own recipe, and the second _vector_ of strings has the ingredients your friend sent you. |
There was a problem hiding this comment.
Suggested change
| The first parameter is a _reference_ to the ingredients of your own recipe, and the second _vector_ of strings has the ingredients your friend sent you. | |
| The first parameter is a _reference_ to the ingredients of your own recipe, and the second has the ingredients your friend sent you. |
There was a problem hiding this comment.
(Partially just suggesting this to kick the CI if it's accepted, but also I don't think we need this bit :))
|
Do you have any ideas @ErikSchierboom |
|
I've closed and reopened, that often works |
|
Thanks @ErikSchierboom |
|
Thanks @vaeng! |
vaeng
added a commit
that referenced
this pull request
Jan 23, 2025
* Update instructions.md The instructions of Task 3 have been clarified. * Correcting after first revision * Update exercises/concept/lasagna-master/.docs/instructions.md Co-authored-by: Christian Willner <[email protected]> * Adding the possibility of using a reference also for the second parameter --------- Co-authored-by: Christian Willner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to try to clarify the instructions of Task 3.