[1.2.1]: Fix deploy script and allow to clear data #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatball133
added
x:rep/medium
meatball133
changed the title
.github/workflows/docs.yml
Outdated
| @@ -1,12 +1,8 @@ | |||
| name: Docs | |||
| on: [push] | |||
There was a problem hiding this comment.
But wouldn't this overwrite the docs whenever a PR is opened? That would mean that the docs are potentially temporarily incorrect
There was a problem hiding this comment.
Yeah I will fix so it only generates new docs on push to the main branch.
.github/workflows/docs.yml
Outdated
| @@ -1,5 +1,11 @@ | |||
| name: Docs | |||
| on: [push] | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
I don't think you want the pull_request bit. What it says (IIRC) is to run when a pull request is opened that targets the main branch. I think you just want the push part.
ErikSchierboom
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.