Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes based on instructions from PR #135 #137

Merged
merged 3 commits into from
Jul 17, 2017
Merged

Changes based on instructions from PR #135 #137

merged 3 commits into from
Jul 17, 2017

Conversation

rpottsoh
Copy link
Member

@rpottsoh rpottsoh commented Jul 16, 2017

ref: #135

@rpottsoh rpottsoh requested review from kytrinyx and kotp July 16, 2017 03:19
@rpottsoh rpottsoh self-assigned this Jul 16, 2017
@kytrinyx
Copy link
Member

@iHiD: this is the first track to implement core exercises! ✨ Do you have any thoughts about structure, etc?

@rpottsoh I don't know a lot about how this will play out, so take anything I say as musings rather than directions or recommendations. My first thought when seeing this is that I think it would be valuable to have at least 2 or three side exercises for each core exercise. I don't know if I'd prefer to have fewer core exercises for now, and then expand both in terms of core and non-core exercises as you add more, or perhaps only have more side exercises for the first core exercises.

I suppose one question I have is whether or not you think that exercises that you add later will be easier or harder than the ones that you already have. If they're more difficult, then you'll probably want to allow for expansion to the core set.

Like I said... I don't really know.

@rpottsoh
Copy link
Member Author

rpottsoh commented Jul 16, 2017

@kytrinyx said:

My first thought when seeing this is that I think it would be valuable to have at least 2 or three side exercises for each core exercise.

I am not clear on how to do this. Should the side exercises "daisy-chain" from the core exercise or should each of the sides be unlocked by the same core exercise? Can an exercise be unlocked by a core exercise directly?

@kytrinyx said:

I suppose one question I have is whether or not you think that exercises that you add later will be easier or harder than the ones that you already have. If they're more difficult, then you'll probably want to allow for expansion to the core set.

I think expansion will be necessary. I think they will be easier and harder. 😄

I am working on an exercise that will be unique to this track (see #91) so am not 100% clear how it will integrate in the grand scheme of things.

@rpottsoh rpottsoh requested a review from iHiD July 16, 2017 04:02
@kytrinyx
Copy link
Member

Should the side exercises "daisy-chain" from the core exercise or should each of the sides be unlocked by the same core exercise?

Each of the sides can be unlocked by the same core exercise. This will mean that once they finish the core exercise, they can choose which of the side exercises to implement, and in which order.

I think expansion will be necessary.

In that case I think I'd recommend starting with fewer core exercises, and adding more as you go.

I am working on an exercise that will be unique to this track

Fun! On our side it doesn't matter whether you make this a core exercise or not—it's really up to you to place it where you think it will do the most good.

@rpottsoh
Copy link
Member Author

Thanks for the explanation and suggestion. Seems to me if an exercise has no exercises unlocked by it then it doesn't need to be a core exercise. Later, it could become a core exercise if some other exercise (likely a new exercise) made sense to be unlocked by it.

@kytrinyx
Copy link
Member

Seems to me if an exercise has no exercises unlocked by it then it doesn't need to be a core exercise.

That's one way of looking at it. Another would be that a core exercise should teach you something meaningful about the language (as opposed to give you a way to practice things you've already been introduced to). I'm not sure either of these is the definitive "right answer".

Made some adjustments after learning more about how "core" and "unlocked_by" are intended to function.  More changes may be in order once more feedback has been received.
Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good starting point.

@rpottsoh
Copy link
Member Author

Agreed. Thanks for reviewing.

@rpottsoh rpottsoh merged commit 2bb17c9 into exercism:master Jul 17, 2017
@rpottsoh rpottsoh deleted the updateConfigJSON branch July 17, 2017 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants