Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unit tests on CI always run with the latest commit from main of the exercism/elixir git submodule #211

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

jiegillet
Copy link
Contributor

Closes #209.

I tried many things and could not understand why git was failing all the time, it turns out that git wasn't installed at all in the hexpm/elixir container. What was confusing is that actions/checkout still worked, that was because there is a backup REST API in case git isn't installed, but in that case the submodules are not handled.

I ended up installing git (which adds 12 seconds to the test CI), checking out the repo and submodule, and then manually updating the submodule. This update is only done in the CI and the update is not committed. I also had to specify the branch to update to in .gitmodules.

Copy link
Member

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit!

@angelikatyborska angelikatyborska merged commit 240df4e into exercism:main Oct 28, 2021
@jiegillet jiegillet deleted the jie-gha-update-submodule branch October 29, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure unit tests on CI always run with the latest commit from main of the exercism/elixir git submodule
2 participants