Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend local calls to match when referencing the current module by name or __MODULE__ #270

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Extend local calls to match when referencing the current module by name or __MODULE__ #270

merged 4 commits into from
Mar 28, 2022

Conversation

angelikatyborska
Copy link
Member

Resolves #267

@angelikatyborska
Copy link
Member Author

I noticed a weird thing, rather unrelated to this PR: Whenever I run mix test, the file test_data/lasagna/perfect_solution/expected_analysis.json gets deleted 🤔

jiegillet
jiegillet approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
This module is getting a bit complex, isn't it? I'm glad it's still possible to understand what's going on and improve it :)

@jiegillet
Copy link
Contributor

I noticed a weird thing, rather unrelated to this PR: Whenever I run mix test, the file test_data/lasagna/perfect_solution/expected_analysis.json gets deleted 🤔

Yeah, this happens to me too, I'm quite puzzled. I'll open an issue if I can't figure it out quickly.

@jiegillet jiegillet merged commit ed11d44 into main Mar 28, 2022
@jiegillet jiegillet deleted the assert-call-local-calls-fix branch March 28, 2022 06:42
@angelikatyborska
Copy link
Member Author

It was quite challenging, yes, but the comments were a big help in figuring out what's what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in basics
2 participants
@angelikatyborska @jiegillet