Add Credo #56
Merged
Add Credo #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+38
to
+43
| # exclude exercise analysis because of snippets in `feature do form do...` | ||
| # they can be unusual, e.g. `_ignore || _ignore` | ||
| "lib/elixir_analyzer/test_suite/", | ||
| # exclude exercise analysis test because of example solutions used in tests | ||
| # those mimic student solutions and might be "bad code" on purpose | ||
| "test/elixir_analyzer/test_suite/" |
There was a problem hiding this comment.
This is the only change in this config that I made, compared to the default config.
| @@ -23,6 +23,7 @@ defmodule ElixirAnalyzer.ExerciseTest do | |||
| # | |||
|
|
|||
| defmacro __before_compile__(env) do | |||
| # credo:disable-for-previous-line Credo.Check.Refactor.CyclomaticComplexity | |||
There was a problem hiding this comment.
This is the only place where I was afraid of splitting this code to reduce cyclomatic complexity, so I took the easy way out...
neenjaw
approved these changes
Apr 24, 2021
Comment on lines
+1
to
+2
| elixir 1.11.3-otp-23 | ||
| erlang 23.2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds credo and fixes all problems reported by it. It also adds the credo check to the CI.
I'm also sneaking in
.tool-versions, the same as the test runner and representer have.