Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code extraction for exercises with separate file for test cases #105

Closed

Conversation

meoconbatu
Copy link
Contributor

Fixes #80

This commit also supports arbitrary test data variable name when test function includes multiple assignments.

This commit also support arbitrary test data variable name when test function
includes multiple assignments.
@meoconbatu meoconbatu requested a review from a team as a code owner July 8, 2023 18:56
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 8, 2023
@junedev
Copy link
Member

junedev commented Sep 3, 2023

@meoconbatu I didn't have time to review this so far and now that I was back from vacation it seems I can't reopen the PR. 🤔

@meoconbatu
Copy link
Contributor Author

@junedev do you have any updates?

@junedev
Copy link
Member

junedev commented Sep 27, 2023

@meoconbatu GitHub seems to suggest the branch you wanted to merge no longer exists. I cannot re-open the PR, the button is disabled. If you still have the code somewhere, maybe you can create a new PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5495932850

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 61 of 75 (81.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 67.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
testrunner/ast.go 60 74 81.08%
Files with Coverage Reduction New Missed Lines %
testrunner/ast.go 3 77.15%
Totals Coverage Status
Change from base Build 5467785147: 1.2%
Covered Lines: 464
Relevant Lines: 692

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5495932850

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 61 of 75 (81.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 67.052%

Changes Missing Coverage Covered Lines Changed/Added Lines %
testrunner/ast.go 60 74 81.08%
Files with Coverage Reduction New Missed Lines %
testrunner/ast.go 3 77.15%
Totals Coverage Status
Change from base Build 5467785147: 1.2%
Covered Lines: 464
Relevant Lines: 692

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test code extraction for exercises with separate file for test cases
3 participants