Unbreak CI after v3 merge (addresses #952) #958
Conversation
Call `configlet lint` instead of `configlet lint .`. Use commit hash cf. GitHub Actions security hardening principles: https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions
This should trigger CI again.
|
I'm just curious and took a look at the error logs - it looks like it's getting closer to being fixed - and I wish I can comment on unchanged lines rather than posting this as a general comment. In for exercise in ${{ github.workspace }}/exercises/*/; dois broken probably due to exercises changing locations, which are now located under |
Rename the script into ``` bin/ensure-practice-exercise-descriptions-are-synced.sh ``` since what was once exercises are now called practice exercises. That which is called concept exercises is not shared between tracks, and so syncing their descriptions is not well-defined. This commit preserves the `override_message`: ``` override_message="I have confirmed ... no README check ..." ``` (censored to avoid triggering CI) in order to not pick a new slogan. While exercism/configlet#179 is being resolved, the only thing we can test is that each practice exercise has an instructions.md, which is the only description file that is always present after #950.
Either 'configlet lint' will report if formatting is wrong, or we could use 'jq' to check basic formatting. Before a decision is made, removing bin/check-configlet-fmt.sh unbreaks CI.
Rename this to contain "-are" like ensure-practice-exercise-descriptions-are-synced.sh Also, chmod +x it.
This should be moved into a separate PR, since it involves a decision to keep this string in one place rather than extract it from the exercises. This also avoids the 'yq' dependency.
Add note wrt. concept exercises and UUIDs.
This was only needed while I was doing pre-PR testing.
This was temporarily disabled, let's see if it causes trouble now.
We may or may not want to have these problems fixed in this PR.
To avoid scope creep, adding the full list of tags is addressed in #939. Note that the formatting of config.json used to be maintained by ``` configlet fmt ``` which is not available in configlet-4.0.0-alpha.4 for v3 tracks. I've tried to emulate the formatting present in config.json already, but we currently do not validate formatting in the same way as we used to.
While the purpose of this is to check out the history far enough back to compare against 'main' (formerly 'master'), it seems that we end up *on* 'main'?
Let's try with just including the entire git history, meh.
|
This PR has a little scope creep, but mostly fixes CI. Unfortunately I will not be able to finish it. I am closing this PR to motivate that it is either reopened by someone who wants to perform the last bits, or redone. |
|
Thanks for all the work! I'm interested and might take a look - seems like tests are all passing - could you be more specific about what needs to be done in this last bit? |
|
I have taken most of these commits, squashed them appropriately, and put them in #981. But I did not choose to take |
After #936, CI no longer works.
This PR addresses the
master->mainbranch rename, as well as the fact thatconfiglet lintwill currently break becauseconfig.jsondoes not conform to the v3 format. Rather than to make it conform, we addcontinue-on-error: trueto the GitHub Action so that the GitHub Actions failures that affect exercises can be addressed.