Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port variable-length-quantity exercise. #960
base: main
Are you sure you want to change the base?
Port variable-length-quantity exercise. #960
Changes from 1 commit
ea57dcc
f6b4e0a
8ed70ad
2ffd9bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you are more informed than me about the purpose of .meta/tests.toml.
I'd have to get back to you about this, or perhaps you can link to where the format and purpose reads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't either, but many other exercise has this file and its content seems straightforward to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example solutions don't have a version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
VariableLengthQuality
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the impression that one word module name seems to be preferred on exercises that have long names, but I couldn't find a good one,
Encode
is probably fine, given thatData.Text.Encoding
intext
does have both encoding and decoding functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to have something like this in an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Something needs to be addressed in this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the purpose of an example is not to be perfect, this is indeed sufficient. So while the following is not a requirement, I wonder if
decodes
would be easier to understand if some of the sub-expressions were named? I'm thinking in particular\next -> ...
and/or the\case ...
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This question cannot currently be answered.
This track's exercise versioning policy is described in the track README:
https://github.com/exercism/haskell#exercise-versioning
Which originally meant "Go to the exercise's canonical-data.json and look up the
version
property". But since exercism/problem-specifications#1674, canonical data no longer contains exercise versions. The reason is political and has to do with people disagreeing about what should go into the problem-specifications repository. Some people got upset, the repository was frozen for a year, and the aftermath is that versioning was removed.Some of the technical argumentation refers to automated test generators:
Since the Haskell track does not employ an automated test generator, the test generator is a person who does use the latest version, but does so manually. This reasoning does not seem to apply to this track as long as we manually maintain test files.
tl;dr: Canonical versions were removed, and our exercise versioning policy depends on them, so we need to make a new versioning policy.