Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hints.md to .meta #1437

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Conversation

jsertel
Copy link
Contributor

@jsertel jsertel commented Apr 26, 2018

For issue #1414 "add reference to tutorial"


Reviewer Resources:

Track Policies

Copy link
Contributor

@sjwarner-bp sjwarner-bp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I am not sure if we also want to regenerate the README as part of this issue or not (@FridaTveit will know - best to double check!)

Copy link
Contributor

@FridaTveit FridaTveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @jsertel! 🙂

As @sjwarner-bp meantioned, please regenerate the readme for this exercise so that these hints are added. There's a description of how to do that in the adding a new exercise section of our contributing doc. Let me know if you have any questions about it! 🙂

Also, a minor thing: in future please reference which exercise you're changing in the pull request title. That makes it easier for us to review it 🙂

@@ -0,0 +1,3 @@
##Hints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this header. A Java Tips header will be inserted above this when the README is generated 🙂

@jsertel
Copy link
Contributor Author

jsertel commented Apr 27, 2018

Thank you @FridaTveit and @sjwarner-bp for bearing with me as I learn these things :)

Copy link
Contributor

@sjwarner-bp sjwarner-bp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🎆

@sjwarner-bp sjwarner-bp merged commit fdec3b7 into exercism:master Apr 30, 2018
@sjwarner-bp
Copy link
Contributor

Nice one @jsertel 👍 Thanks for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants