-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added hints.md to .meta #1437
added hints.md to .meta #1437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I am not sure if we also want to regenerate the README as part of this issue or not (@FridaTveit will know - best to double check!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @jsertel! 🙂
As @sjwarner-bp meantioned, please regenerate the readme for this exercise so that these hints are added. There's a description of how to do that in the adding a new exercise section of our contributing doc. Let me know if you have any questions about it! 🙂
Also, a minor thing: in future please reference which exercise you're changing in the pull request title. That makes it easier for us to review it 🙂
@@ -0,0 +1,3 @@ | |||
##Hints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this header. A Java Tips
header will be inserted above this when the README is generated 🙂
Thank you @FridaTveit and @sjwarner-bp for bearing with me as I learn these things :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 🎆
Nice one @jsertel 👍 Thanks for the addition! |
For issue #1414 "add reference to tutorial"
Reviewer Resources:
Track Policies