Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concept]: Arrow Functions #1414

Merged
merged 16 commits into from
Oct 9, 2021

Conversation

pertrai1
Copy link
Contributor

@pertrai1 pertrai1 commented Oct 7, 2021

This introduces the concept for arrow functions. Looking forward to feedback on my first full concept.

closes #1340

@junedev junedev added x:size/medium Medium amount of work hacktoberfest-accepted Opt-in to hacktoberfest labels Oct 7, 2021
Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done overall! Suggested some minor improvements and left a comment for you how to fix the CI error.

config.json Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.meta/design.md Outdated Show resolved Hide resolved
config.json Show resolved Hide resolved
concepts/arrow-functions/links.json Show resolved Hide resolved
concepts/arrow-functions/introduction.md Outdated Show resolved Hide resolved
concepts/arrow-functions/introduction.md Outdated Show resolved Hide resolved
concepts/arrow-functions/introduction.md Outdated Show resolved Hide resolved
@pertrai1
Copy link
Contributor Author

pertrai1 commented Oct 8, 2021

@junedev @SleeplessByte I have made the changes. Please take a look when you get a chance.

@junedev
Copy link
Member

junedev commented Oct 9, 2021

@pertrai1 I applied some minor wording changes and used the new first sentence of the concept as blurb as well.

Regarding the exercise introduction: If an exercises teaches two concepts you can use two h2 headers (##) to separate the content. You don't have to merge it. I did this here as well. That way we can transport more information from the new arrow functions concept.

One more general comment: Try to avoid things like "like this:", "here is an example". Usually its sufficient to just have a sentence and then the example below without referring to it explicitly.

@junedev junedev merged commit 98302b4 into exercism:main Oct 9, 2021
@pertrai1
Copy link
Contributor Author

pertrai1 commented Oct 9, 2021

@junedev - thank you for the awesome feedback. I will keep the points in mind moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest x:size/medium Medium amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Concept Exercise "Fruit Picker": Add Concept arrow-functions
3 participants