-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Concept]: Arrow Functions #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done overall! Suggested some minor improvements and left a comment for you how to fix the CI error.
@junedev @SleeplessByte I have made the changes. Please take a look when you get a chance. |
@pertrai1 I applied some minor wording changes and used the new first sentence of the concept as blurb as well. Regarding the exercise introduction: If an exercises teaches two concepts you can use two h2 headers (##) to separate the content. You don't have to merge it. I did this here as well. That way we can transport more information from the new arrow functions concept. One more general comment: Try to avoid things like "like this:", "here is an example". Usually its sufficient to just have a sentence and then the example below without referring to it explicitly. |
@junedev - thank you for the awesome feedback. I will keep the points in mind moving forward. |
This introduces the concept for arrow functions. Looking forward to feedback on my first full concept.
closes #1340