Issue 1341 inheritance concept #1447

jakewitcher · 2021-10-17T02:09:17Z

Fixes #1341

…er/javascript into issue-1341-inheritance-concept

…ntroduction

…oduction for inheritance

…s to errors in concept introduction and about

SleeplessByte

If you make the formatting change first (to all .md files) it's easier to review too.

concepts/errors/about.md

concepts/errors/introduction.md

github-actions · 2021-10-17T15:32:33Z

Dear jakewitcher

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

📜 The following files usually contain very similar content.
- concepts/<concept>/about.md
- concepts/<concept>/introduction.md
- exercises/concept/<exercise>/.docs/introduction.md
Please check whether the changes you made to one of these also need to be applied to the others.
✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.
🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)
🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.
🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

_{Automated comment created by PR Commenter 🤖.}

…rors

SleeplessByte

Looking good. A few nit-picks.

@junedev what do you think?

concepts/inheritance/about.md

SleeplessByte · 2021-10-17T19:25:36Z

concepts/inheritance/about.md

+class Pet {
+  constructor(name) {
+    this.name = name;
+  }
+}
+
+class Dog extends Pet {
+    constructor(name, breed) {
+        super(name);
+        this.breed = breed;
+    }
+}
+
+let dog = new Dog('Otis', 'Pug');


This looks like inconsistent indentation. I think we use 2 spaces everywhere. After this review, I will run format on your PR and it should auto-update.

Format fixed it, see this commit

concepts/errors/introduction.md

concepts/inheritance/about.md

concepts/inheritance/introduction.md

exercises/concept/factory-sensors/.docs/introduction.md

SleeplessByte · 2021-10-17T19:30:26Z

/format

SleeplessByte · 2021-10-17T19:31:19Z

Sidenote, according to configlet lint, the following errors are present:

The Concept Exercise factory-sensors has inheritance in its concepts, which is not a slug in the top-level concepts array: /home/runner/work/javascript/javascript/config.json
/home/runner/work/javascript/javascript/concepts contains a directory named inheritance, which is not a slug in the concepts array. Please add the concept to that array: /home/runner/work/javascript/javascript/config.json

Both can be solved with the same change.

SleeplessByte · 2021-10-17T19:32:02Z

(Closing and re-opening so that the CI checks run again)

junedev · 2021-10-17T19:46:36Z

.gitignore

@@ -2,3 +2,4 @@
 /bin/configlet
 /pnpm-lock.yaml
 /yarn.lock
+/.idea


Please use a global gitignore file on your local machine for excluding editor/IDE related folders. We don't want this file to grow with each new editor a contributor brings along.

Removed from the project .gitignore and added to global .gitignore

junedev · 2021-10-17T20:02:19Z

@SleeplessByte I trust your review of the content. I double checked the general structure, looks all good (besides the missing concept entry the linter mentioned).

@jakewitcher Well done overall, thanks a lot!

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

… all inheritance related md files

jakewitcher · 2021-10-18T02:39:32Z

I believe I have addressed all of the outstanding issues, let me know if there's anything I have missed. Thanks for all of your feedback and patience, this was my first non-trivial PR for an Exercism language track and it was really helpful for learning about the overall structure of the track code bases and the PR expectations.

jakewitcher added 14 commits October 9, 2021 23:42

add .idea directory to gitignore

f11a691

init commit

4db432d

update design.md and global config.json with inheritance concept

2ac1058

edit text, fix errors in examples

5eb95e1

add .idea directory to gitignore

2d143a2

init commit

83004c7

update design.md and global config.json with inheritance concept

cef0d63

edit text, fix errors in examples

c6ef884

Merge branch 'issue-1341-inheritance-concept' of github.com:jakewitch…

29918bb

…er/javascript into issue-1341-inheritance-concept

edit about, add section on prototype inheritance, reduce content in i…

a57501a

…ntroduction

edit text in about and introduction for inheritance concept

fd51d19

edit errors concept and factory-sensors introduction

58a8d5f

edit section on inheritance and the prototype chain in about and intr…

c3bd811

…oduction for inheritance

add inheritance section to factory-sensors introduction, match change…

cdc38d8

…s to errors in concept introduction and about

SleeplessByte requested changes Oct 17, 2021

View reviewed changes

concepts/errors/about.md Outdated Show resolved Hide resolved

concepts/errors/introduction.md Outdated Show resolved Hide resolved

remove hard wrap from md lines, each sentence placed on its own line

6962ba4

jakewitcher added 2 commits October 17, 2021 11:37

rephrase line in Errors docs on using inheritance to create custom er…

904a2f7

…rors

mention the extends keyword to text on creating custom errors

34a142a

SleeplessByte approved these changes Oct 17, 2021

View reviewed changes

[CI] Format code

4439986

SleeplessByte closed this Oct 17, 2021

SleeplessByte reopened this Oct 17, 2021

junedev reviewed Oct 17, 2021

View reviewed changes

junedev added hacktoberfest-accepted Opt-in to hacktoberfest x:size/medium Medium amount of work labels Oct 17, 2021

jakewitcher and others added 12 commits October 17, 2021 21:39

group related sentences in inheritance about.md

3b3d546

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

group related sentences in inheritance about.md

6193128

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

replace let with const

3daa0f1

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

replace let with const

7fc882a

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

group related sentences in inheritance introduction.md

df13d3a

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

replace let with const

9a2c6be

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

update Error class reference to be inline code

b10f08c

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

change let to const

ed89b05

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

group related sentences in factory-sensors exercise introduction.md

a927072

Co-authored-by: Derk-Jan Karrenbeld <[email protected]>

use const in all inheritance examples, group related sentences across…

be06b65

… all inheritance related md files

remove ide directory from gitignore

616ba12

add inheritance slug to top-level concepts array

6966556

junedev merged commit 5ac1fb3 into exercism:main Oct 18, 2021

pertrai1 pushed a commit to pertrai1/javascript that referenced this pull request Oct 22, 2021

Add inheritance concept (exercism#1447)

1da89a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 1341 inheritance concept #1447

Issue 1341 inheritance concept #1447

jakewitcher commented Oct 17, 2021 •

edited by SleeplessByte

Loading

SleeplessByte left a comment

github-actions bot commented Oct 17, 2021

SleeplessByte left a comment

SleeplessByte Oct 17, 2021

SleeplessByte Oct 17, 2021

SleeplessByte commented Oct 17, 2021

SleeplessByte commented Oct 17, 2021

SleeplessByte commented Oct 17, 2021

junedev Oct 17, 2021

jakewitcher Oct 18, 2021

junedev commented Oct 17, 2021

jakewitcher commented Oct 18, 2021

Issue 1341 inheritance concept #1447

Issue 1341 inheritance concept #1447

Conversation

jakewitcher commented Oct 17, 2021 • edited by SleeplessByte Loading

SleeplessByte left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2021

Dear jakewitcher

Dear Reviewer/Maintainer

SleeplessByte left a comment

Choose a reason for hiding this comment

SleeplessByte Oct 17, 2021

Choose a reason for hiding this comment

SleeplessByte Oct 17, 2021

Choose a reason for hiding this comment

SleeplessByte commented Oct 17, 2021

SleeplessByte commented Oct 17, 2021

SleeplessByte commented Oct 17, 2021

junedev Oct 17, 2021

Choose a reason for hiding this comment

jakewitcher Oct 18, 2021

Choose a reason for hiding this comment

junedev commented Oct 17, 2021

jakewitcher commented Oct 18, 2021

jakewitcher commented Oct 17, 2021 •

edited by SleeplessByte

Loading