-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tests for Allergies #2568
Updating tests for Allergies #2568
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
@jagdish-15 seems like you missed formatting. The CI is unhappy. |
Upon running the linting command |
Sorry, I didn't have much time to look at things but you seem to have figured it out. |
I was unable to pinpoint the issue with the I plan to raise a separate PR specifically for the path changes in the Thank you so much for the references! Now that I'm familiar with all the linting and formatting tools, I can work on the next exercises more efficiently. |
The problem is that That said, to fix formatting, running format on the PR is always possible. To do that post a message to the PR with: /format |
The "Format code" action has started running. |
The "Format code" action has finished running. |
For security reasons,
|
Pull Request
This PR syncs
tests.toml
with theproblem-specifications
repository and incorporates the new tests into the test file. These updates follow the approval in PR #2567.npx cross-env ASSIGNMENT=practice/allergies babel-node scripts/test
PS C:\Programming\Exercism\javascript> npx cross-env ASSIGNMENT=practice/allergies babel-node scripts/test