Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed footer macros, generated test file and run #3419

Closed
wants to merge 15 commits into from

Conversation

gelbelle
Copy link
Contributor

@gelbelle gelbelle commented May 9, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@BethanyG
Copy link
Member

BethanyG commented May 9, 2023

WOOOT! Thank you for this (and all your hard work on the git-foo). 🌟 🚀

(approving now, but holding on merging so that we can get an update on the re-queue flag)

@BethanyG BethanyG added the do not merge 🚧 Don't merge until this label is removed. label May 9, 2023
@gelbelle
Copy link
Contributor Author

gelbelle commented Jun 1, 2023

All the footers are done, test files regenerated, and examples checked against new tests.

@BethanyG
Copy link
Member

BethanyG commented Jun 1, 2023

@gelbelle - Many thanks!. 🌟 🌈

Unfortunately, due to delays with work related to #3373, I don't know when we'll be able to merge this.
#3423 & #3419 are also pending the changes discussed in #3373.

@BethanyG
Copy link
Member

BethanyG commented Jun 1, 2023

@gelbelle - WOAH. Just realized that you pushed these updates to your last branch/PR. 😱 These should be in several new branches/PRs -- we don't want all 114 files in one change. At most (as discussed) we would have 3-5 exercise changes per PR.

I know this is a small change - but it's easer for rollback (and for fixing CI failures) if we sub-group these instead of doing them in a large chunk like this. Many thanks.

@BethanyG BethanyG self-requested a review June 1, 2023 17:55
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gelbelle - per comment, please break this up into several PRs. At most, we'd like 3-5 exercises per PR. I know it is a PITA, but these are easier (and safer) to sub-group, rather than doing everything in one branch/PR. Thanks. 💙 Additionally, we've got some exercises failing CI because they need to have their test files re-generatied, so we need to double check that.

@BethanyG
Copy link
Member

BethanyG commented Jun 6, 2023

Thanks for the individual PRs! I've reopened them, but do have to mark them as "Do not merge" until we get #3373 all tested and merged.

Meanwhile, I will close this behemoth. 😄

@BethanyG BethanyG closed this Jun 6, 2023
@BethanyG BethanyG removed the do not merge 🚧 Don't merge until this label is removed. label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants