Grade school for Racket #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exercise is kind of a mess. The instructions are vague and I see a lot of variabilty among the different implementations. The canonical data indicates that the roster should throw away the grade levels, but following the example of C++, I have retained them in hash->list format. One of the tests seems flat wrong, and I noticed that other languages skipped it, but I have fixed it to match what seems to be its intent.
|
I'll take a look this weekend. I recall porting it once before, and yeah it was all over the place. |
BNAndras
added
x:module/practice-exercise
BNAndras
requested changes
Mar 18, 2024
I inadvertently implemented three tests that are marked reimplemented. The tests.toml file shows that two tests reimplement the same one (is that allowed?) a0c7b9b8-0e89-47f8-8b4a-c50f885e79d1 => c125dab7-2a53-492f-a99a-56ad511940d8 6a03b61e-1211-4783-a3cc-fc7f773fba3f => c125dab7-2a53-492f-a99a-56ad511940d8 and each of these is reimplemented in turn: d7982c4f-1602-49f6-a651-620f2614243a => a0c7b9b8-0e89-47f8-8b4a-c50f885e79d1 c7ec1c5e-9ab7-4d3b-be5c-29f2f7a237c5 => 6a03b61e-1211-4783-a3cc-fc7f773fba3f Thanks to Andras for checking my work.
BNAndras
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exercise is kind of a mess. The instructions are vague and I see a lot of variabilty among the different implementations. The canonical data indicates that the roster should throw away the grade levels, but following the example of C++, I have retained them in hash->list format. One of the tests seems flat wrong, and I noticed that other languages skipped it, but I have fixed it to match what seems to be its intent.