-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints to hello-world exercise #222
Add hints to hello-world exercise #222
Conversation
I love this. The only thing I'm not sure of, is the link for the no-null hint. It now links to Wikipedia, but I think a Scala-specific link would be better. I've managed to find this explanation, which does are fairly good job of explaning why you shouldn't use |
@ErikSchierboom I was also not too happy about this link, but couldn't find anything nice (incl. your link which I also considered too theoretical for beginners). |
Much better. I think it is at least good enough until we find something better. |
3e7742c
to
0dc0883
Compare
changed the link. |
@@ -0,0 +1,8 @@ | |||
## Hints | |||
For this exercise two Scala features come in handy: | |||
1. [Default Parameter Values](http://docs.scala-lang.org/tutorials/tour/default-parameter-values.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add an empty line before the 1.
: https://github.com/abo64/xscala/blob/0dc08838d532af9f02ede9c7617fca03369f85fc/exercises/hello-world/HINTS.md
0dc0883
to
d068c1c
Compare
@ErikSchierboom Seems it cannot handle these ordered lists. |
Looks good. @ricemery would you like to merge the PR's yourselves, or should we (the other maintainers) also be allowed to do that? Perhaps we should make it a rul that we cannot merge our own PR's, to prevent overlooking mistakes. |
I found this quite plausible. But: |
Indeed. But now that we have several maintainers, I think we could try to not merge our own PR's. But I don't know what the others thing about this. |
Most often the rules without any exceptions are the best. |
Agreed. By default we should not merge our own PRs.
…On Thu, Dec 1, 2016 at 4:53 AM abo64 ***@***.***> wrote:
Most often the rules without any exceptions are the best.
So I also think we should try to never merge our own PRs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#222 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABeHG1IjHDsAAM9_omNLtKD6CC7MrdZOks5rDrVJgaJpZM4LAH6X>
.
|
@ricemery So it would be okay if I merged this PR? |
Absolutely!
Thanks
…On Thu, Dec 1, 2016 at 10:08 AM Erik Schierboom ***@***.***> wrote:
@ricemery <https://github.com/ricemery> So it would be okay if I merged
this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#222 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABeHG1NuJdhwmP1Kxczb7AQ_mSbPHhiYks5rDv8agaJpZM4LAH6X>
.
|
Thanks @abo64! |
#220 add
HINTS.md
tohello-world
exercise.Question is whether we should agree on a common format for those hints?