Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints to hello-world exercise #222

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

abo64
Copy link
Contributor

@abo64 abo64 commented Nov 30, 2016

#220 add HINTS.md to hello-world exercise.
Question is whether we should agree on a common format for those hints?

@ErikSchierboom
Copy link
Member

I love this. The only thing I'm not sure of, is the link for the no-null hint. It now links to Wikipedia, but I think a Scala-specific link would be better. I've managed to find this explanation, which does are fairly good job of explaning why you shouldn't use return. It might be a bit difficult for newbies though.

@abo64
Copy link
Contributor Author

abo64 commented Nov 30, 2016

@ErikSchierboom I was also not too happy about this link, but couldn't find anything nice (incl. your link which I also considered too theoretical for beginners).
Now I just searched again and stumbled upon this. What do you think?

@ErikSchierboom
Copy link
Member

Much better. I think it is at least good enough until we find something better.

@abo64 abo64 force-pushed the issue-220-hints-hello-world branch 2 times, most recently from 3e7742c to 0dc0883 Compare December 1, 2016 07:21
@abo64
Copy link
Contributor Author

abo64 commented Dec 1, 2016

changed the link.

@@ -0,0 +1,8 @@
## Hints
For this exercise two Scala features come in handy:
1. [Default Parameter Values](http://docs.scala-lang.org/tutorials/tour/default-parameter-values.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abo64 abo64 force-pushed the issue-220-hints-hello-world branch from 0dc0883 to d068c1c Compare December 1, 2016 10:08
@abo64
Copy link
Contributor Author

abo64 commented Dec 1, 2016

@ErikSchierboom Seems it cannot handle these ordered lists.
Changed it to an unordered list (using hyphens).

@ErikSchierboom
Copy link
Member

Looks good.

@ricemery would you like to merge the PR's yourselves, or should we (the other maintainers) also be allowed to do that? Perhaps we should make it a rul that we cannot merge our own PR's, to prevent overlooking mistakes.

@abo64
Copy link
Contributor Author

abo64 commented Dec 1, 2016

I found this quite plausible. But:
Avoid merging your own pull requests (but it's fine if it's really simple) - the question is always what is "really simple".

@ErikSchierboom
Copy link
Member

Indeed. But now that we have several maintainers, I think we could try to not merge our own PR's. But I don't know what the others thing about this.

@abo64
Copy link
Contributor Author

abo64 commented Dec 1, 2016

Most often the rules without any exceptions are the best.
So I also think we should try to never merge our own PRs.

@ricemery
Copy link
Member

ricemery commented Dec 1, 2016 via email

@ErikSchierboom
Copy link
Member

@ricemery So it would be okay if I merged this PR?

@ricemery
Copy link
Member

ricemery commented Dec 1, 2016 via email

@ErikSchierboom ErikSchierboom merged commit b066e22 into exercism:master Dec 1, 2016
@ErikSchierboom
Copy link
Member

Thanks @abo64!

@abo64 abo64 deleted the issue-220-hints-hello-world branch July 4, 2017 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants