Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust resistor-color difficulty #241

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

keiravillekode
Copy link
Contributor

No description provided.

Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@keiravillekode keiravillekode mentioned this pull request Sep 19, 2024
@@ -1,3 +1,7 @@
default rel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we omit this line from the example solution, we see

/usr/bin/ld: resistor_color.o: relocation R_X86_64_32S against `.data' can not be used when making a PIE object; recompile with -fPIE                                     
/usr/bin/ld: failed to set dynamic section sizes: bad value                          
collect2: error: ld returned 1 exit status                                           
make: *** [Makefile:32: tests] Error 1

That error does not guide people to add default rel

@@ -1,3 +1,7 @@
default rel

section .data
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we omit this line from the example solution, so the array is in section .rodata, we see

/usr/bin/ld: resistor_color.o: warning: relocation in read-only section `.rodata'    
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE                                   
collect2: error: ld returned 1 exit status                                           
make: *** [Makefile:32: tests] Error 1

We can guide students away from experiencing this error.

@keiravillekode keiravillekode merged commit 1544e18 into exercism:main Dec 30, 2024
7 checks passed
@keiravillekode keiravillekode deleted the resistor-color branch December 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants